This revision was automatically updated to reflect the committed changes.
Closed by commit R302:bc916a6be818: Dont check twice if the icon exists
from ::availableSizes (authored by apol).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D17828?vs=48273=48346#toc
REPOSITORY
R302
cfeck added a comment.
Maybe add 'const found = ', while you are at it.
REPOSITORY
R302 KIconThemes
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17828
To: apol, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
cfeck accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R302 KIconThemes
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17828
To: apol, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
It's done by iconName() as well as by the method itself.
TEST PLAN
Tests pass, apps
