D17856: Fix a regression introduced in 6a1852

2018-12-30 Thread Jos van den Oever
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:f403d09d0b49: Fix a regression introduced in 6a1852 
(authored by vandenoever).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17856?vs=48363=48393

REVISION DETAIL
  https://phabricator.kde.org/D17856

AFFECTED FILES
  src/core/kconfigini.cpp

To: vandenoever, dfaure, arichardson, apol, aacid, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17856: Fix a regression introduced in 6a1852

2018-12-29 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  fixutf8 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17856

To: vandenoever, dfaure, arichardson, apol, aacid, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17856: Fix a regression introduced in 6a1852

2018-12-29 Thread Jos van den Oever
vandenoever added reviewers: dfaure, arichardson, apol, aacid, ngraham.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17856

To: vandenoever, dfaure, arichardson, apol, aacid, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17856: Fix a regression introduced in 6a1852

2018-12-29 Thread Jos van den Oever
vandenoever created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vandenoever requested review of this revision.

REVISION SUMMARY
  Bytes from 'Strings' of type GroupString and KeyString should not be
  escaped because they are valid UTF-8. Only instances of ValueString
  should be escaped.
  
  This fixes the failing test KConfigTest::testEncoding

TEST PLAN
  Ran `ninja test` and found no errors.

REPOSITORY
  R237 KConfig

BRANCH
  fixutf8 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17856

AFFECTED FILES
  src/core/kconfigini.cpp

To: vandenoever
Cc: kde-frameworks-devel, michaelh, ngraham, bruns