D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

ngraham added a comment. BTW you still need to correct your `~/.gitconfig` file to have your real name and email address. :) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17907 To: rooty, ngraham, #frameworks, #vdg, #plasma Cc: cfeck, filipf, kde-frameworks

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

This revision was automatically updated to reflect the committed changes. Closed by commit R236:dc901a1f0b5f: [KWidgetsAddons] Do not use light font styles for headings (3/3) (authored by Krešimir Čohar , committed by ngraham). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LA

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

ngraham removed a dependent revision: D17916: [Login and lock screens] Do not use light font styles for the sddm clock. REPOSITORY R236 KWidgetsAddons BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17907 To: rooty, ngraham, #frameworks, #vdg,

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

rooty added a dependent revision: D17916: [Login and lock screens] Do not use light font styles for the sddm clock. REPOSITORY R236 KWidgetsAddons BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17907 To: rooty, ngraham, #frameworks, #vdg, #pl

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

rooty updated this revision to Diff 48502. rooty added a comment. Removed empty line (formerly line 242) REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17907?vs=48497&id=48502 BRANCH no-light-headings (branched from master) REVISION DETAIL http

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

cfeck added inline comments. INLINE COMMENTS > ktitlewidget.cpp:242 > d->textLabel->setStyleSheet(d->textStyleSheet()); > -//Qt stylesheet doesn't support lighter font-weight > -QFont font(d->textLabel->font()); > -if (d->level <= 4) { > -font.setWeight(QFont::Light); > -

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Strongly approve for all the reasons given in https://bugs.kde.org/show_bug.cgi?id=402730. Let's wait a bit though to make sure the #plasma

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

rooty edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17907 To: rooty, ngraham, #frameworks, #vdg, #plasma Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

rooty edited the summary of this revision. rooty edited the test plan for this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17907 To: rooty, ngraham, #frameworks, #vdg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

rooty edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17907 To: rooty, ngraham, #frameworks, #vdg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

rooty edited reviewers, added: VDG, Plasma; removed: cfeck. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17907 To: rooty, ngraham, #frameworks, #vdg, #plasma, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

rooty retitled this revision from "[frameworks] Do not use light font styles for headings (3/3)" to "[KWidgetsAddons] Do not use light font styles for headings (3/3)". rooty edited reviewers, added: Frameworks; removed: kde-frameworks-devel. Herald added a subscriber: kde-frameworks-devel. REPOS