astippich updated this revision to Diff 49750.
astippich added a comment.
- fix gps altitude precision
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18010?vs=49317=49750
BRANCH
fix_zero_gps
REVISION DETAIL
https://phabricator.kde.org/D18010
astippich added inline comments.
INLINE COMMENTS
> bruns wrote in exiv2extractor.cpp:298
> when you rewrite this as
>
> if (it != data.end()) {
> auto ratio = it->value().toRational();
> it = data.findKey(Exiv2::ExifKey("Exif.GPSInfo.GPSAltitudeRef"));
> if ((ratio.second !=
bruns added inline comments.
INLINE COMMENTS
> exiv2extractor.cpp:298
> }
> }
> return alt;
when you rewrite this as
if (it != data.end()) {
auto ratio = it->value().toRational();
it = data.findKey(Exiv2::ExifKey("Exif.GPSInfo.GPSAltitudeRef"));
if
bruns accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
fix_zero_gps
REVISION DETAIL
https://phabricator.kde.org/D18010
To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
astippich added a dependency: D18205: test empty and zero gps data.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D18010
To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abrahams
astippich updated this revision to Diff 49317.
astippich added a comment.
- rebase on revision
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18010?vs=48789=49317
BRANCH
fix_zero_gps
REVISION DETAIL
https://phabricator.kde.org/D18010
AFFECTED
bruns requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D18010
To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns,
bruns added a comment.
Can you create two test files, one with e.g. altitude == 0, and one without
altitude?
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D18010
To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,
astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.
REVISION SUMMARY
A zero value was used before to indicate invalid
data, and thus 0°
