D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R276:649157422e4e: [kitemviews] Change the search in Desktop 
Behavior/Activities to more in line… (authored by Krešimir Čohar 
, committed by GB_2).

REPOSITORY
  R276 KItemViews

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18046?vs=49041&id=49260

REVISION DETAIL
  https://phabricator.kde.org/D18046

AFFECTED FILES
  src/ktreewidgetsearchline.cpp
  src/ktreewidgetsearchlinewidget.cpp

To: rooty, #vdg, #plasma, kde-frameworks-devel, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Much better, thanks!

REPOSITORY
  R276 KItemViews

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18046

To: rooty, #vdg, #plasma, kde-frameworks-devel, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

[Root]

rooty updated this revision to Diff 49041.
rooty added a comment.


  Fix blunder and bring back search field, place "Search..." in search field

REPOSITORY
  R276 KItemViews

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18046?vs=48876&id=49041

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18046

AFFECTED FILES
  src/ktreewidgetsearchline.cpp
  src/ktreewidgetsearchlinewidget.cpp

To: rooty, #vdg, #plasma, kde-frameworks-devel, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This has the effect of //removing// the search fields for all the shortcut 
chooser views. That doesn't seem like the intent here.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D18046

To: rooty, #vdg, #plasma, kde-frameworks-devel, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

[Root]

rooty added a task: T10258: Use correct search bars and use ellipsis whenever 
needed to follow the KDE HIG.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D18046

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

[Root]

rooty added reviewers: VDG, Plasma, kde-frameworks-devel.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D18046

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

[Root]

rooty created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch removes the "Search:" portion of Activities (in System Settings, 
Desktop Behavior --> Workspace) and adds "Search..." to the search field.

REPOSITORY
  R276 KItemViews

BRANCH
  kitemviews-searchellipsis (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18046

AFFECTED FILES
  src/ktreewidgetsearchline.cpp
  src/ktreewidgetsearchlinewidget.cpp

To: rooty
Cc: kde-frameworks-devel, michaelh, ngraham, bruns