D18076: Suggest people to use K_PLUGIN_CLASS_WITH_JSON

2019-01-08 Thread Albert Astals Cid 
aacid closed this revision.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D18076

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18076: Suggest people to use K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18076

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18076: Suggest people to use K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  It's simpler to understand than K_PLUGIN_FACTORY_WITH_JSON that asks
  you for a factory name but you never know which name to use, until you
  realize the name doesn't matter at all.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18076

AFFECTED FILES
  src/services/kplugininfo.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns