D18081: Make translations work

2019-01-09 Thread Albert Astals Cid 
aacid closed this revision.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D18081

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18081: Make translations work

2019-01-08 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R290 KPackage

BRANCH
  arcpatch-D18081

REVISION DETAIL
  https://phabricator.kde.org/D18081

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18081: Make translations work

2019-01-08 Thread Albert Astals Cid 
aacid updated this revision to Diff 49034.
aacid added a comment.


  remove unrelated cmake changes

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18081?vs=48932=49034

BRANCH
  arcpatch-D18081

REVISION DETAIL
  https://phabricator.kde.org/D18081

AFFECTED FILES
  src/kpackagetool/kpackagetool.cpp
  src/kpackagetool/main.cpp
  src/kpackagetool/options.h

To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18081: Make translations work

2019-01-07 Thread Aleix Pol Gonzalez 
apol added a comment.


  LGTM otherwise

INLINE COMMENTS

> CMakeLists.txt:4
>  set(KF5_VERSION "5.54.0") # handled by release scripts
> -set(KF5_DEP_VERSION "5.54.0") # handled by release scripts
> +set(KF5_DEP_VERSION "5.53.0") # handled by release scripts
>  project(KPackage VERSION ${KF5_VERSION})

Wrong?

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D18081

To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18081: Make translations work

2019-01-07 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  Do not call i18n from global static variables since qcoreapplication is
  still not around yet and that makes it fail

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18081

AFFECTED FILES
  CMakeLists.txt
  src/kpackagetool/kpackagetool.cpp
  src/kpackagetool/main.cpp
  src/kpackagetool/options.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns