D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file
This revision was automatically updated to reflect the committed changes. Closed by commit R240:ed985869924f: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18088?vs=48942&id=50281 REVISION DETAIL https://phabricator.kde.org/D18088 AFFECTED FILES find-modules/FindGperf.cmake To: kossebau, #frameworks, pino, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH skipautomoxforgperf REVISION DETAIL https://phabricator.kde.org/D18088 To: kossebau, #frameworks, pino, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file
kossebau added a comment. Not sure if there ever s a chance somebody would inject QObject code into such a generated file? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18088 To: kossebau, #frameworks, pino Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file
kossebau created this revision. kossebau added reviewers: Frameworks, pino. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Avoids to have manually set the property on the generated source file to deal with changed CMake policy CMP0071. REPOSITORY R240 Extra CMake Modules BRANCH skipautomoxforgperf REVISION DETAIL https://phabricator.kde.org/D18088 AFFECTED FILES find-modules/FindGperf.cmake To: kossebau, #frameworks, pino Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns