D18134: KEncodingProber: Delete copy constructor and assignment operator

This revision was automatically updated to reflect the committed changes. Closed by commit R270:d5ffc242950b: KEncodingProber: Delete copy constructor and assignment operator (authored by aacid). REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE

D18134: KEncodingProber: Delete copy constructor and assignment operator

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R270 KCodecs BRANCH master REVISION DETAIL https://phabricator.kde.org/D18134 To: aacid, vkrause Cc: apol, vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D18134: KEncodingProber: Delete copy constructor and assignment operator

apol added a comment. In D18134#390150 , @vkrause wrote: > As discussed on IRC, I think this is "only" SIC, not BIC. I'd therefore agree with Albert's reasoning for this change (and same for D18135 ).

D18134: KEncodingProber: Delete copy constructor and assignment operator

vkrause added a comment. As discussed on IRC, I think this is "only" SIC, not BIC. I'd therefore agree with Albert's reasoning for this change (and same for D18135 ). REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D18134 To:

D18134: KEncodingProber: Delete copy constructor and assignment operator

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY If someone was using them, it'd crash since it was raw-copying the d pointer so you would end up with a double delete.