D18134: KEncodingProber: Delete copy constructor and assignment operator

2019-01-10 Thread Albert Astals Cid 
This revision was automatically updated to reflect the committed changes.
Closed by commit R270:d5ffc242950b: KEncodingProber: Delete copy constructor 
and assignment operator (authored by aacid).

REPOSITORY
  R270 KCodecs

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18134?vs=49105=49191

REVISION DETAIL
  https://phabricator.kde.org/D18134

AFFECTED FILES
  src/kencodingprober.h

To: aacid, vkrause
Cc: apol, vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D18134: KEncodingProber: Delete copy constructor and assignment operator

2019-01-10 Thread Volker Krause 
vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R270 KCodecs

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18134

To: aacid, vkrause
Cc: apol, vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D18134: KEncodingProber: Delete copy constructor and assignment operator

2019-01-09 Thread Aleix Pol Gonzalez 
apol added a comment.


  In D18134#390150 , @vkrause wrote:
  
  > As discussed on IRC, I think this is "only" SIC, not BIC. I'd therefore 
agree with Albert's reasoning for this change (and same for D18135 
).
  
  
  that's what I thought when I saw the other patch.

REPOSITORY
  R270 KCodecs

REVISION DETAIL
  https://phabricator.kde.org/D18134

To: aacid
Cc: apol, vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D18134: KEncodingProber: Delete copy constructor and assignment operator

2019-01-09 Thread Volker Krause 
vkrause added a comment.


  As discussed on IRC, I think this is "only" SIC, not BIC. I'd therefore agree 
with Albert's reasoning for this change (and same for D18135 
).

REPOSITORY
  R270 KCodecs

REVISION DETAIL
  https://phabricator.kde.org/D18134

To: aacid
Cc: vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D18134: KEncodingProber: Delete copy constructor and assignment operator

2019-01-09 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  If someone was using them, it'd crash since it was raw-copying the d pointer
  so you would end up with a double delete.
  
  This is BIC, but IMHO it's fine, whoever gets a compiler failure has a bug to 
fix

REPOSITORY
  R270 KCodecs

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18134

AFFECTED FILES
  src/kencodingprober.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns