D18135: KEmailSettings: Delete copy constructor and assignment operator
This revision was automatically updated to reflect the committed changes. Closed by commit R237:78da515c5deb: KEmailSettings: Delete copy constructor and assignment operator (authored by aacid). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18135?vs=49107&id=49192 REVISION DETAIL https://phabricator.kde.org/D18135 AFFECTED FILES src/core/kemailsettings.h To: aacid, vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18135: KEmailSettings: Delete copy constructor and assignment operator
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D18135 To: aacid, vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18135: KEmailSettings: Delete copy constructor and assignment operator
aacid updated this revision to Diff 49107. aacid added a comment. typo REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18135?vs=49106&id=49107 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18135 AFFECTED FILES src/core/kemailsettings.h To: aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18135: KEmailSettings: Delete copy constructor and assignment operator
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY If someone was using them, it'd crash since it was raw-copying the d pointer so you would end up with a double delete. This is BIC, but IMHO it's fine, whoever gets a compiler failure has a bug to fix REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D18135 AFFECTED FILES CMakeLists.txt src/core/kemailsettings.h To: aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns
