D18178: fix environment setup of klanguagename test
This revision was automatically updated to reflect the committed changes. Closed by commit R265:5ba6283e4ec1: fix environment setup of klanguagename test (authored by sitter). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18178?vs=49224&id=49433 REVISION DETAIL https://phabricator.kde.org/D18178 AFFECTED FILES autotests/klanguagenametest.cpp To: sitter, aacid, rikmills Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18178: fix environment setup of klanguagename test
sitter edited the summary of this revision. REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D18178 To: sitter, aacid, rikmills Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18178: fix environment setup of klanguagename test
rikmills accepted this revision. rikmills added a comment. This revision is now accepted and ready to land. Build and passes on Kubuntu CI now. https://launchpadlibrarian.net/405807438/buildlog_ubuntu-disco-amd64.kconfigwidgets_5.54.0+p19.04+git20190111.1036-0_BUILDING.txt.gz REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D18178 To: sitter, aacid, rikmills Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18178: fix environment setup of klanguagename test
sitter created this revision. sitter added reviewers: aacid, rikmills. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY - use correct env vars LANG and LANGUAGE - as an additional safety-net explicitly set QLocale default to english (the latter kinda overrides the former, but better save than sorry since it has no adverse effects to do both) this should make tests pass regardless of potentially weird env states some CIs may have TEST PLAN test passes on kubuntu ci. my theory is that QLocale picked the default before the env was set up and therefore used `C` instead of `en` thus bypassing the en=>en_US coercion REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D18178 AFFECTED FILES autotests/klanguagenametest.cpp To: sitter, aacid, rikmills Cc: kde-frameworks-devel, michaelh, ngraham, bruns
