D18215: Improve the preferences-desktop-cryptography icon

2019-01-13 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:a7154ef3053c: Improve the 
preferences-desktop-cryptography icon (authored by trickyricky26, committed by 
ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18215?vs=49390=49392

REVISION DETAIL
  https://phabricator.kde.org/D18215

AFFECTED FILES
  icons-dark/mimetypes/32/preferences-desktop-cryptography.svg
  icons-dark/preferences/32/preferences-desktop-cryptography.svg
  icons/mimetypes/32/preferences-desktop-cryptography.svg
  icons/preferences/32/preferences-desktop-cryptography.svg

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-13 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  There we go!

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-preferences-cryptography (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18215

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-13 Thread TrickyRicky 
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18215

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-13 Thread TrickyRicky 
trickyricky26 updated this revision to Diff 49390.
trickyricky26 added a comment.


  - Actually change the icon to match preferences-system-network-iscsi

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18215?vs=49381=49390

BRANCH
  improve-preferences-cryptography (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18215

AFFECTED FILES
  icons-dark/mimetypes/32/preferences-desktop-cryptography.svg
  icons-dark/preferences/32/preferences-desktop-cryptography.svg
  icons/mimetypes/32/preferences-desktop-cryptography.svg
  icons/preferences/32/preferences-desktop-cryptography.svg

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-13 Thread Nathaniel Graham 
ngraham added a comment.


  Hmm, I don't actually see any changes compares to the previous version. There 
are still subtle visual differences between the two icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18215

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-13 Thread TrickyRicky 
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18215

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-13 Thread TrickyRicky 
trickyricky26 updated this revision to Diff 49381.
trickyricky26 added a comment.


  - Match the preferences-system-network-iscsi style

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18215?vs=49360=49381

BRANCH
  improve-preferences-cryptography (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18215

AFFECTED FILES
  icons-dark/mimetypes/32/preferences-desktop-cryptography.svg
  icons-dark/preferences/32/preferences-desktop-cryptography.svg
  icons/mimetypes/32/preferences-desktop-cryptography.svg
  icons/preferences/32/preferences-desktop-cryptography.svg

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-12 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Much better than the original, but if we're trying to emulate the existing 
style, we should come as close to pixel-perfect as we can. :)
  
  Compare your new icon to the existing `preferences-system-network-iscsi` 
icon, which uses the same style:
  
  F6546965: Crypto.png 
  
  F6546966: iscsi.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18215

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-12 Thread TrickyRicky 
trickyricky26 updated this revision to Diff 49360.
trickyricky26 added a comment.


  - widen the right part of the SATA connector to be more symmterical

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18215?vs=49356=49360

BRANCH
  improve-preferences-cryptography (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18215

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-cryptography.svg
  icons/preferences/32/preferences-desktop-cryptography.svg

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-12 Thread TrickyRicky 
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18215

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-12 Thread TrickyRicky 
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18215

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-12 Thread TrickyRicky 
trickyricky26 updated this revision to Diff 49356.
trickyricky26 added a comment.


  - Shift the lock upwards a bit, remove bottom left shadow

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18215?vs=49354=49356

BRANCH
  improve-preferences-cryptography (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18215

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-cryptography.svg
  icons/preferences/32/preferences-desktop-cryptography.svg

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-12 Thread TrickyRicky 
trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18215

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-12 Thread TrickyRicky 
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18215

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-12 Thread TrickyRicky 
trickyricky26 updated this revision to Diff 49354.
trickyricky26 added a comment.


  - Remove Plasma logo and shadow of the white label

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18215?vs=49351=49354

BRANCH
  improve-preferences-cryptography (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18215

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-cryptography.svg
  icons/preferences/32/preferences-desktop-cryptography.svg

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-12 Thread TrickyRicky 
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18215

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-12 Thread TrickyRicky 
trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18215

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-12 Thread TrickyRicky 
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18215

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18215: Improve the preferences-desktop-cryptography icon

2019-01-12 Thread TrickyRicky 
trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-preferences-cryptography (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18215

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-cryptography.svg
  icons/preferences/32/preferences-desktop-cryptography.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns