D18237: Fix ResultIterator

aacid added a comment. In D18237#402918 , @bruns wrote: > Oh, and you forgot to undelete the operator=, so this is still BIC ... No, that is not BIC REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To:

D18237: Fix ResultIterator

bruns added a comment. Oh, and you forgot to undelete the operator=, so this is still BIC ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko, apol Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D18237: Fix ResultIterator

bruns added a comment. The correct way to **fix** this is by allocating a new ResultIteratorPrivate and "copying" the QStringList. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko, apol Cc: apol, kde-frameworks-devel, #baloo,

D18237: Fix ResultIterator

aacid closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko, apol Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18237: Fix ResultIterator

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH arcpatch-D18237 REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko, apol Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D18237: Fix ResultIterator

aacid updated this revision to Diff 50533. aacid added a comment. update so not to break BC REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18237?vs=49413=50533 BRANCH arcpatch-D18237 REVISION DETAIL https://phabricator.kde.org/D18237 AFFECTED FILES

D18237: Fix ResultIterator

aacid reclaimed this revision. aacid added a comment. Ok, that makes sense REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D18237: Fix ResultIterator

apol added a comment. Maybe it could make sense to deprecate the copy constructor and add the move operator? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D18237: Fix ResultIterator

aacid abandoned this revision. aacid added a comment. Hmmm, you're right, this is Source Compatible but not Binary Compatible. I guess i'll discard this and hope people don't really misuses it. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid,

D18237: Fix ResultIterator

apol added a comment. Do you think BC is a problem here then? Won't applications be using it as you described start failing? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov,

D18237: Fix ResultIterator

aacid added a comment. ping REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18237: Fix ResultIterator

ngraham added reviewers: Baloo, bruns, poboiko. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18237: Fix ResultIterator

aacid set the repository for this revision to R293 Baloo. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid Cc: kde-frameworks-devel, #baloo, ashaposhnikov,