anthonyfieroni abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D18249
To: anthonyfieroni, davidedmundson, broulik, ngraham, mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
anthonyfieroni added a comment.
I investigate on testing this patch, it does not fix systray issue, to
discard it?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D18249
To: anthonyfieroni, davidedmundson, broulik, ngraham, mart, #plasma
Cc:
anthonyfieroni updated this revision to Diff 49630.
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18249?vs=49469=49630
REVISION DETAIL
https://phabricator.kde.org/D18249
AFFECTED FILES
src/declarativeimports/core/datamodel.cpp
To:
anthonyfieroni added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in datamodel.cpp:379
> Optimization is you have [5, 6, 8] then [5, 6, 8, 9] so it make only
> beginInsertRows({}, 3, 3);
> full replace (m_items[sourceName] = list.toVector();)
> endInsertRows()
> Same if you [5, 6]
>
anthonyfieroni added inline comments.
INLINE COMMENTS
> davidedmundson wrote in datamodel.cpp:379
> I don't understand what you're changing here, can you provide a bit more
> detail on the exact problem.
Optimization is you have [5, 6, 8] then [5, 6, 8, 9] so it make only
beginInsertRows({},
davidedmundson added inline comments.
INLINE COMMENTS
> datamodel.cpp:55-61
> +const QHash roles = sourceModel()->roleNames();
> +m_roleIds.reserve(roles.count());
> +for (auto i = roles.constBegin(); i != roles.constEnd(); ++i) {
> m_roleIds[QString::fromUtf8(i.value())] =
anthonyfieroni created this revision.
anthonyfieroni added reviewers: davidedmundson, broulik, ngraham, mart, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
anthonyfieroni requested review of this revision.
REVISION SUMMARY
I give a try to rework
