D18253: Move the Android API level checks to runtime

2019-01-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:e9a35ccb2a60: Move the Android API level checks to runtime (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18253?vs=49486&id=49550 REV

D18253: Move the Android API level checks to runtime

2019-01-15 Thread Volker Krause
vkrause added a comment. In D18253#393283 , @apol wrote: > Maybe we could print something for adb logcat that says that notifications won't be working? Android itself is already doing that. And support for older API levels is hopefully n

D18253: Move the Android API level checks to runtime

2019-01-14 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Maybe we could print something for adb logcat that says that notifications won't be working? REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D18

D18253: Move the Android API level checks to runtime

2019-01-14 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This doesn't make notifications on API level < 23 work yet, but it allows us to build against lower API levels and hav