D18263: [CopyJob] Provide more descriptive notification header
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> copyjob.cpp:344
> +const QString destStr =
> KStringHandler::csqueeze(m_dest.toDisplayString(QUrl::PreferLocalFile), 100);
> +m_description = i18n("%1 %2 to %3", modeStr, itemStr, destStr);
> +}
translators won't know what to do with this word puzzle. Better do
const QString str = m_mode == CopyJob::Copy ? i18n("Copying %1 to %2") :
i18n("Moving %1 to %2");
> job.cpp:123
> +static const QString s_defaultTitle = i18nc("@title job", "Moving");
> +static const QString s_title = jobTitle(job, s_defaultTitle);
> static const QString s_source = i18nc("The source of a file operation",
> "Source");
You can't make this static, otherwise the very first job will determine what
all subsequent jobs will get in s_title.
And then remove the s_ prefix, of course.
(*3)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18263
To: chinmoyr, dfaure, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18263: [CopyJob] Provide more descriptive notification header
chinmoyr added a comment. They emit a generic message. A descriptive message can only generated from within job. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18263 To: chinmoyr, dfaure, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18263: [CopyJob] Provide more descriptive notification header
broulik added a comment. Isn't that done by `emitCopying` et al? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18263 To: chinmoyr, dfaure, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18263: [CopyJob] Provide more descriptive notification header
chinmoyr created this revision. chinmoyr added reviewers: dfaure, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY A job can internally set a more descriptive title or a generic title will be provided for the notification applet. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18263 AFFECTED FILES src/core/copyjob.cpp src/core/job.cpp src/core/job_p.h To: chinmoyr, dfaure, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns
