ahmadsamir added a comment.
I've split the changes to the Loader in https://phabricator.kde.org/D18907.
And will hopefully try to handle the Ui part in this current diff.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D18317
To: ahmadsamir, sandsmark, loh.tar
loh.tar added a comment.
My observations:
- There is no hint when you activate auto spell check (yes, it's out of this
scope)
- Before showing the combobox by "Change Dictionary" the popup appears
- The combobox shows then some other setting, here it was the first entry
- When open
ahmadsamir added a reviewer: loh.tar.
ahmadsamir added a subscriber: pino.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D18317
To: ahmadsamir, sandsmark, loh.tar
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
ahmadsamir updated this revision to Diff 50486.
ahmadsamir retitled this revision from "Don't fail if defaultLanguage
dictionary can't be loaded" to "Display an error message if loading a
dictionary fails".
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this