D18329: Remove the AndroidX support library dependency

2019-01-19 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:8536ef7e67a5: Remove the AndroidX support library dependency (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18329?vs=49737=49887

D18329: Remove the AndroidX support library dependency

2019-01-19 Thread Nicolas Fella
nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D18329 To: vkrause, nicolasfella Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D18329: Remove the AndroidX support library dependency

2019-01-18 Thread Aleix Pol Gonzalez
apol added subscribers: nicolasfella, apol. apol added a comment. LGTM, @nicolasfella? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D18329 To: vkrause Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D18329: Remove the AndroidX support library dependency

2019-01-17 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Turns out we don't actually need that, the version checks in the Java code accomplish the same. More importantly, it