D18450: Add extractor for AppImage files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1aa7f9168d51: Add extractor for AppImage files (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18450?vs=51934=52352#toc REPOSITORY R286 KFileMetaData CHANGES SINCE

D18450: Add extractor for AppImage files

kossebau updated this revision to Diff 51934. kossebau added a comment. - update to latest master - remove unused name() method REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18450?vs=50535=51934 BRANCH addappimageextractor REVISION DETAIL

D18450: Add extractor for AppImage files

kossebau added a comment. In D18450#402995 , @astippich wrote: > Just noticed, you never use the AppDataParser.name(). Is that intentional? Good catch, was left over from first code drafts, before I aligned the data mapping with what I

D18450: Add extractor for AppImage files

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. Just noticed, you never use the AppDataParser.name(). Is that intentional? Otherwise looks good, but you may want to wait for someone more experienced than me. REPOSITORY R286

D18450: Add extractor for AppImage files

kossebau added a comment. In D18450#402952 , @astippich wrote: > got it up and running! Yay :) Thanks for keeping trying. > One question: Why is the extra desktop file parser necessary? Shouldn't all required information be

D18450: Add extractor for AppImage files

astippich added a comment. got it up and running! One question: Why is the extra desktop file parser necessary? Shouldn't all required information be available from the app data parser? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18450 To: kossebau,

D18450: Add extractor for AppImage files

astippich added a comment. In D18450#402175 , @TheAssassin wrote: > `LIBAPPIMAGE_BINARIES` (or, more likely, `LIBAPPIMAGE_LIBRARIES`) doesn't exist, maybe it existed for a short while but got deleted. @kossebau can you please link to

D18450: Add extractor for AppImage files

kossebau updated this revision to Diff 50535. kossebau added a comment. rely completely on working libappimage cmake config files, as avail with recent releases REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18450?vs=50146=50535 BRANCH

D18450: Add extractor for AppImage files

kossebau added a comment. Given there are now released versions of libappimage which provide cmake config files, I will now update this patch to simply only support those. Distributions will be encouraged to also get the latest version of libappimage anyway. REPOSITORY R286 KFileMetaData

D18450: Add extractor for AppImage files

TheAssassin added a comment. You can use a system Google test installation by setting `-DUSE_SYSTEM_GTEST=ON`, IIRC. But it's easier to simply `git submodule --init --recursive`. `LIBAPPIMAGE_BINARIES` doesn't exist, maybe it existed for a short while but got deleted. @kossebau can you

D18450: Add extractor for AppImage files

kossebau added a comment. @astippich Thanks for the update. I see that myself I built libappimage with USE_SYSTEM_LIBARCHIVE:BOOL=ON, USE_SYSTEM_SQUASHFUSE:BOOL=OFF, USE_SYSTEM_XZ:BOOL=ON, BUILD_TESTING:BOOL=OFF (cannot remember why I configured the build that way when I initially set it

D18450: Add extractor for AppImage files

astippich added a comment. The first issue is when BUILD_TESTING is not set to false, cmake fails with CMake Error at lib/CMakeLists.txt:8 (add_subdirectory): The source directory ~/Code/libappimage-0.1.8/lib/gtest does not contain a CMakeLists.txt file.

D18450: Add extractor for AppImage files

TheAssassin added a comment. In D18450#400865 , @astippich wrote: > I am having troubles getting it to build (Kubuntu 18.10). Unfortunately, I could not find pre-build packages for libappimage. I have overcome two small issues in building

D18450: Add extractor for AppImage files

kossebau added a comment. In D18450#400865 , @astippich wrote: > I am having troubles getting it to build (Kubuntu 18.10). Unfortunately, I could not find pre-build packages for libappimage. I have overcome two small issues in building

D18450: Add extractor for AppImage files

astippich added a comment. I am having troubles getting it to build (Kubuntu 18.10). Unfortunately, I could not find pre-build packages for libappimage. I have overcome two small issues in building libappimage, but now I can't get it to work in KFileMetaData because cmake complains that

D18450: Add extractor for AppImage files

kossebau added a comment. In D18450#398143 , @astippich wrote: > Can you add a test please? Done. The sample file sadly is some 2xx KB big, but the AppImage devs could not help to get it smaller without no longer being a real appimage,

D18450: Add extractor for AppImage files

kossebau updated this revision to Diff 50146. kossebau added a comment. add unit test REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18450?vs=50077=50146 BRANCH addappimageextractor REVISION DETAIL https://phabricator.kde.org/D18450 AFFECTED

D18450: Add extractor for AppImage files

astippich added a comment. Can you add a test please? In D18450#397920 , @kossebau wrote: > There seems to be some bug with the Comment field though, somehow in Dolphin the comment is not shown, where "dump" displays it as existing.

D18450: Add extractor for AppImage files

kossebau updated this revision to Diff 50077. kossebau added a comment. - skip getting the unlocalized description if there is a localized one REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18450?vs=50073=50077 BRANCH addappimageextractor

D18450: Add extractor for AppImage files

kossebau updated this revision to Diff 50073. kossebau added a comment. - switch and use any localized versions found matching the current system locale, should be more expected - also extract appdata and expose as plain text, even though that can be quite some data, but that's the UI's

D18450: Add extractor for AppImage files

broulik added a comment. Cool! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18450 To: kossebau, #baloo Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18450: Add extractor for AppImage files

kossebau added a comment. Example screenshot: F6561839: Screenshot_20190122_102745.png There seems to be some bug with the Comment field though, somehow in Dolphin the comment is not shown, where "dump" displays it as existing. REPOSITORY R286

D18450: Add extractor for AppImage files

kossebau created this revision. kossebau added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Only a few properties currently can be mapped more or less to the existing