D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

Codezela added a comment. can i talk about other thing why the vlise button have this circle around it i think it will look cleaner with simple border strock or with only the close red circle REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

rooty added a comment. In D18545#400222 , @rooty wrote: > In D18545#400220 , @filipf wrote: > > > Really nice, I think it fits in more with how edges are drawn elsewhere. > > > > Could you also

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18545 To: rooty, #vdg, ngraham Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

filipf added a comment. Really nice, I think it fits in more with how edges are drawn elsewhere. Could you also add screenshots with Breeze Dark? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18545 To: rooty, #vdg, ngraham Cc: filipf,

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

rooty added a comment. In D18545#400214 , @ngraham wrote: > Wow, it's amazing how much nicer the After screenshot looks than the Before. Such a difference from a tiny change! +1 Thanks! And thanks to Noah Davis for giving me a boost

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

ngraham added a comment. Wow, it's amazing how much nicer the After screenshot looks than the Before. Such a difference from a tiny change! +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18545 To: rooty, #vdg, ngraham Cc:

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

rooty edited the test plan for this revision. rooty added reviewers: VDG, ngraham. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18545 To: rooty, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

rooty created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rooty requested review of this revision. REVISION SUMMARY This patch aims to make the corners of the dialog/notification backgrounds (dialogs/background.svgz) more rounded and more