D18563: Don't create directory tree when a new folder has a '/' in the name

shubham abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure, elvisangelaccio, pino, kde-frameworks-devel,

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham added a comment. I've submitted a proposed replacement for this as D21907: Show feedback inline when creating new files or folders . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks,

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham added a comment. Yes, I plan to put it up for review today or tomorrow. Sorry for the long wait! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: andriusr, emateli, cfeck,

D18563: Don't create directory tree when a new folder has a '/' in the name

shubham added a comment. @ngraham Are you working on it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure, elvisangelaccio,

D18563: Don't create directory tree when a new folder has a '/' in the name

shubham added a comment. @ngraham Any updates? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure, elvisangelaccio, pino,

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham added a comment. I'm working on an alternative user interface for this feature. Stay tuned! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: andriusr, emateli, cfeck,

D18563: Don't create directory tree when a new folder has a '/' in the name

shubham added a comment. Any more ideas?, I'm a bit confused REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure,

D18563: Don't create directory tree when a new folder has a '/' in the name

andriusr added a comment. Also, Windows does not allow filenames with either `\` or `/` REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: andriusr, emateli, cfeck, acrouthamel, markg,

D18563: Don't create directory tree when a new folder has a '/' in the name

andriusr added inline comments. INLINE COMMENTS > ngraham wrote in knewfilemenu.cpp:907 > If Windows allows slashes in the filename, shouldn't they just be a part of > the filename and not create a directory tree? If so, then we don't even need > this `#ifdef` condition at all;

D18563: Don't create directory tree when a new folder has a '/' in the name

emateli added a comment. Agree, something similar is being proposed over at D18384 . These dialogs are getting out of hand. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure,

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham added a comment. Here's an idea for an overall nicer user experience: instead of letting people choose whatever name they want in the new file & new folder dialogs and then displaying an error message (inline or in dialog form) once they click "OK", we could have the new file & new

D18563: Don't create directory tree when a new folder has a '/' in the name

markg added a comment. In D18563#402216 , @ngraham wrote: > It's rather ironic that in D18571 , I endorse a hidden productivity booster feature, but here, I reject one. :) > > I think I'm reconsidering.

D18563: Don't create directory tree when a new folder has a '/' in the name

cfeck added a comment. It could ask what to do. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: cfeck, acrouthamel, markg, ndavis, dfaure, elvisangelaccio, pino, kde-frameworks-devel,

D18563: Don't create directory tree when a new folder has a '/' in the name

shubham added a comment. It's difficult to know the intentions of the user whether they wanted to create a single directory with slash in it or a directory tree. So this patch is stuck in between the two. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To:

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham added a comment. Well now I am. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: acrouthamel, markg, ndavis, dfaure, elvisangelaccio, pino, kde-frameworks-devel, michaelh,

D18563: Don't create directory tree when a new folder has a '/' in the name

ndavis added a comment. In D18563#402216 , @ngraham wrote: > It's rather ironic that in D18571 , I endorse a hidden productivity booster feature, but here, I reject one. :) > > I think I'm reconsidering.

D18563: Don't create directory tree when a new folder has a '/' in the name

acrouthamel added a comment. -1 from me. I would prefer we stick to Unix methodologies. KDE software is also known to be the more feature-rich and customizable options out there, and as mentioned commonly linked to power users. We would be wise to not introduce a feature

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. It's rather ironic that in D18571 , I endorse a hidden productivity booster feature, but here, I reject one. :) I think I'm

D18563: Don't create directory tree when a new folder has a '/' in the name

elvisangelaccio added a comment. I'm also a bit puzzled: are we removing a feature in order to show an error message instead? REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino

D18563: Don't create directory tree when a new folder has a '/' in the name

markg added a comment. In D18563#401979 , @shubham wrote: > @ndavis UNIX does not allow / in any valid identifier name. > Also looking at the bug report, it feels like people wanted to create a folder named "a/b/c" which UNEXPECTEDLY created

D18563: Don't create directory tree when a new folder has a '/' in the name

shubham added a comment. @ndavis UNIX does not allow / in any valid identifier name. REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: ndavis, dfaure, elvisangelaccio, pino,

D18563: Don't create directory tree when a new folder has a '/' in the name

ndavis added a comment. So if I want to make 2 folders at once, `~/a` and `~/a/b`, this patch removes that ability? If so, I don't like this change. REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure,

D18563: Don't create directory tree when a new folder has a '/' in the name

shubham added a dependent revision: D18599: Use specific error message if file/folder name contains '/'. REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: dfaure,

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham added a comment. Then we should define a new error message specifically for this case. That's probably material for another patch. REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure,

D18563: Don't create directory tree when a new folder has a '/' in the name

shubham added a comment. @ngraham The message you suggested is specific, on the other hand failure in creation of directory may also be due to the file/directory name reserved by OS (eg .. ) REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To:

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham added a comment. How about "Could not create because slashes are not allowed in file and folder names." REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: dfaure,

D18563: Don't create directory tree when a new folder has a '/' in the name

shubham added a comment. @ngraham Okay with changing error message string, please provide me with the best suitable string. REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham retitled this revision from "Don't allow '/' in new directory's name" to "Don't create directory tree when a new folder has a '/' in the name". ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham,

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham accepted this revision as: ngraham. ngraham added reviewers: dfaure, elvisangelaccio, pino. ngraham added subscribers: pino, elvisangelaccio, dfaure. ngraham added a comment. This revision is now accepted and ready to land. Makes sense to me. Please don't land this until you receive

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham added a comment. We might want to also consider improving the error message for this situation. I think it would be appropriate to do so in this patch. REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks,