D18599: Use specific error message if file/folder name contains '/'

shubham abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18599 To: shubham, ngraham, #vdg, #frameworks, #dolphin Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

ngraham added a comment. I've submitted a proposed replacement for this as D21907: Show feedback inline when creating new files or folders . REPOSITORY R241 KIO BRANCH err REVISION DETAIL https://phabricator.kde.org/D18599 To: shubham, ngraham,

D18599: Use specific error message if file/folder name contains '/'

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great, thanks. REPOSITORY R241 KIO BRANCH err REVISION DETAIL https://phabricator.kde.org/D18599 To: shubham, ngraham, #vdg, #frameworks, #dolphin Cc: kde-frameworks-devel,

D18599: Use specific error message if file/folder name contains '/'

shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18599 To: shubham, ngraham, #vdg, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

shubham updated this revision to Diff 50496. shubham marked an inline comment as done. shubham added a comment. Fix trailing spaces REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18599?vs=50495=50496 BRANCH err REVISION DETAIL

D18599: Use specific error message if file/folder name contains '/'

shubham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18599 To: shubham, ngraham, #vdg, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

ngraham added inline comments. INLINE COMMENTS > global.h:251 > ERR_OWNER_DIED = KJob::UserDefinedError + 75, ///< Value used between > kuiserver and views when the job owner disappears unexpectedly. It should not > be emitted by slaves. @since 5.54 > +

D18599: Use specific error message if file/folder name contains '/'

shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18599 To: shubham, ngraham, #vdg, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18599 To: shubham, ngraham, #vdg, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

shubham updated this revision to Diff 50495. shubham added a comment. 1. #ifndef Q_OS_WIN for the error message REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18599?vs=50494=50495 BRANCH err REVISION DETAIL https://phabricator.kde.org/D18599 AFFECTED

D18599: Use specific error message if file/folder name contains '/'

ngraham added reviewers: VDG, Frameworks, Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18599 To: shubham, ngraham, #vdg, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > knewfilemenu.cpp:905 > KIO::Job *job; > -if (name.contains(QLatin1Char('/'))) { > -// If the name contains any slashes, use mkpath so that

D18599: Use specific error message if file/folder name contains '/'

shubham updated this revision to Diff 50494. shubham added a comment. Remove unintentionally included header REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18599?vs=50493=50494 BRANCH err REVISION DETAIL https://phabricator.kde.org/D18599 AFFECTED FILES

D18599: Use specific error message if file/folder name contains '/'

shubham created this revision. shubham added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY Depends on D18563 REPOSITORY R241 KIO