This revision was automatically updated to reflect the committed changes.
Closed by commit R265:c0cc6b8a200a: Cache the default KColorScheme
configuration (authored by mwolff).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D18612?vs=50541=51212#toc
REPOSITORY
R265 KConfigWidgets
mwolff added a comment.
pushed this now with a proper benchmark too, shows a ~10x performance win
when a non-empty PATH is set
REPOSITORY
R265 KConfigWidgets
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18612
To: mwolff, #kate, #kdevelop, dfaure, broulik
Cc: broulik,
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R265 KConfigWidgets
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18612
To: mwolff, #kate, #kdevelop, dfaure, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
mwolff added a comment.
sure, but first let's get this in. @broulik or @dfaure care to give your +1?
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D18612
To: mwolff, #kate, #kdevelop, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
broulik added a comment.
I also noticed that on application startup two default color schemes are
created: One by plasma-integration set on `QApplication` and the other by
`QStyle::standardPalette()` in the widget style.
I couldn't figure out a way to avoid this (have QStyle use the
mwolff added a comment.
I see that it's faster when I profile kate/kdev, but I cannot easily write a
benchmark for this. It's only noticeable when the KDE_COLOR_SCHEME_PATH
variable is set, otherwise the global application config will be used afte
rall, which is going to be shared most
mwolff created this revision.
mwolff added reviewers: Kate, KDevelop, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mwolff requested review of this revision.
REVISION SUMMARY
KDevelop, Kate and probably other applications too, recreate
