D18675: Use different "None" item icon in grid view KCMs

2019-02-03 Thread Björn Feber 
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:e22529eeed0c: Use different "None" item icon in 
grid view KCMs (authored by GB_2).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18675?vs=50774&id=50775

REVISION DETAIL
  https://phabricator.kde.org/D18675

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

2019-02-03 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Master only please.

REPOSITORY
  R296 KDeclarative

BRANCH
  use-different-icon-for-none-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg, ngraham
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

2019-02-03 Thread Björn Feber 
GB_2 edited the summary of this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

2019-02-03 Thread Björn Feber 
GB_2 updated this revision to Diff 50774.
GB_2 added a comment.


  Use new `edit-none` icon

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18675?vs=50724&id=50774

BRANCH
  use-different-icon-for-none-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18675

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

2019-02-02 Thread Björn Feber 
GB_2 added a comment.


  In D18675#404096 , @GB_2 wrote:
  
  > In D18675#404090 , @ngraham 
wrote:
  >
  > > Hmm, I like the use of an X here, but I'm not sure the red color is 
appropriate. Nothing is being removed, deleted, or destroyed.
  >
  >
  > Yeah, it's the only X icon, I think we need to make a copy of it that is 
not red in `breeze-icons` (we could call it `edit-none` or something).
  
  
  Let's do this then.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

2019-02-02 Thread Nathaniel Graham 
ngraham added a comment.


  Yeah, the item already has a "None" label; we're just trying to figure out 
what the icon should be. I think an X is okay choice for suggesting "there's 
nothing here".

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

2019-02-02 Thread Björn Feber 
GB_2 added a comment.


  In D18675#404104 , @abetts wrote:
  
  > > Seems like a bit too much. BTW, this is the Plasma login splash and there 
is no text output when disabled.
  >
  > I see, maybe the label could be more descriptive then? Use something like 
"Black", or "No splash"?
  
  
  I think "None" is fine, because you already know that you are selecting the 
splash screen and if it was specific to the splash this would be a bit more 
complicated to change and this wouldn't be for all KCMs that can have a "None" 
item then.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

2019-02-02 Thread Andres Betts 
abetts added a comment.


  > Seems like a bit too much. BTW, this is the Plasma login splash and there 
is no text output when disabled.
  
  I see, maybe the label could be more descriptive then? Use something like 
"Black", or "No splash"?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

2019-02-02 Thread Björn Feber 
GB_2 added a comment.


  In D18675#404097 , @abetts wrote:
  
  > In D18675#404090 , @ngraham 
wrote:
  >
  > > Hmm, I like the use of an X here, but I'm not sure the red color is 
appropriate. Nothing is being removed, deleted, or destroyed.
  >
  >
  > I agree with you here. It may seem that you are selecting something 
different. What about a stop sign and behind it a representation of the splash 
screen. So as to signal that you are not wanting a splash screen. The concept 
is great though! Many people care little for the splash screen and prefer to 
see the booting output.
  
  
  Seems like a bit too much. BTW, this is the Plasma login splash that shows no 
text output.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

2019-02-02 Thread Björn Feber 
GB_2 added a comment.


  In D18675#404090 , @ngraham wrote:
  
  > Hmm, I like the use of an X here, but I'm not sure the red color is 
appropriate. Nothing is being removed, deleted, or destroyed.
  
  
  Yeah, it's the only X icon, I think we need to make a copy of it that is not 
red in `breeze-icons` (we could call it `edit-none` or something).

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

2019-02-02 Thread Andres Betts 
abetts added a comment.


  In D18675#404090 , @ngraham wrote:
  
  > Hmm, I like the use of an X here, but I'm not sure the red color is 
appropriate. Nothing is being removed, deleted, or destroyed.
  
  
  I agree with you here. It may seem that you are selecting something 
different. What about a stop sign and behind it a representation of the splash 
screen. So as to signal that you are not wanting a splash screen. The concept 
is great though! Many people care little for the splash screen and prefer to 
see the booting output.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

2019-02-02 Thread Nathaniel Graham 
ngraham added a comment.


  Hmm, I like the use of an X here, but I'm not sure the red color is 
appropriate. Nothing is being removed, deleted, or destroyed.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

2019-02-02 Thread Björn Feber 
GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Changes the icon for the "None" item in grid view KCMs (present in the Splash 
Screen KCM) to differentiate it from other items that have no preview.
  F6583130: Grid View KCM None Item Icon.png 


TEST PLAN
  Open the Splash Screen KCM.

REPOSITORY
  R296 KDeclarative

BRANCH
  use-different-icon-for-none-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18675

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns