D18761: Add icon name to service providers in .desktop file

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8657a239a28d: Add icon name to service providers in 
.desktop file (authored by shubham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18761?vs=50953=50969

REVISION DETAIL
  https://phabricator.kde.org/D18761

AFFECTED FILES
  src/urifilters/ikws/searchproviders/google.desktop
  src/urifilters/ikws/searchproviders/wikipedia.desktop
  src/urifilters/ikws/searchproviders/yahoo.desktop
  src/urifilters/ikws/searchproviders/youtube.desktop

To: shubham, broulik, ngraham, #vdg, #okular, #frameworks
Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh, squeakypancakes, 
alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, 
tfella, firef, ngraham, bruns, skadinna, darcyshen, aaronhoneycutt, aacid, 
mbohlender

D18761: Add icon name to service providers in .desktop file

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  icon

REVISION DETAIL
  https://phabricator.kde.org/D18761

To: shubham, broulik, ngraham, #vdg, #okular, #frameworks
Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh, squeakypancakes, 
alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, 
tfella, firef, ngraham, bruns, skadinna, darcyshen, aaronhoneycutt, aacid, 
mbohlender

D18761: Add icon name to service providers in .desktop file

[Shubham]

shubham added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18761

To: shubham, broulik, ngraham, #vdg, #okular, #frameworks
Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh, squeakypancakes, 
alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, 
tfella, firef, ngraham, bruns, skadinna, darcyshen, aaronhoneycutt, aacid, 
mbohlender

D18761: Add icon name to service providers in .desktop file

[Shubham]

shubham added a comment.


  In the rest of service providers, very few have any icon specified, and most 
don't have.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18761

To: shubham, broulik, ngraham, #vdg, #okular
Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh, squeakypancakes, 
alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, 
tfella, firef, ngraham, bruns, skadinna, darcyshen, aaronhoneycutt, aacid, 
mbohlender

D18761: Add icon name to service providers in .desktop file

[Shubham]

shubham added reviewers: VDG, Okular.
shubham added projects: Okular, VDG.
shubham added a subscriber: Okular.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18761

To: shubham, broulik, ngraham, #vdg, #okular
Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh, squeakypancakes, 
alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, 
tfella, firef, ngraham, bruns, skadinna, darcyshen, aaronhoneycutt, aacid, 
mbohlender

D18761: Add icon name to service providers in .desktop file

[Shubham]

shubham created this revision.
shubham added reviewers: broulik, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.

REVISION SUMMARY
  Earlier all entries had same icon ie. "text-html"
  See also D18755 

TEST PLAN
  1. Open any document
  2. Choose Selection and select some area of the document
  3. Context menu appears. Go on search for ...
  4. New icons

REPOSITORY
  R241 KIO

BRANCH
  icon

REVISION DETAIL
  https://phabricator.kde.org/D18761

AFFECTED FILES
  src/urifilters/ikws/searchproviders/google.desktop
  src/urifilters/ikws/searchproviders/wikipedia.desktop
  src/urifilters/ikws/searchproviders/yahoo.desktop
  src/urifilters/ikws/searchproviders/youtube.desktop

To: shubham, broulik, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns