This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c063b1ce8489: Add support for portals in KRun (authored
by GeeXT, committed by ngraham).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18762?vs=52163&id=52239
REVISIO
ngraham added a comment.
No problem, I'll take care of this for you!
REPOSITORY
R241 KIO
BRANCH
flatpak_open_url (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D18762
To: GeeXT, jgrulich, apol, dfaure, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
GeeXT added a comment.
@apol I didn't applied for KDE Developer Account yet (I'm new here) so I
can't, sorry.
REPOSITORY
R241 KIO
BRANCH
flatpak_open_url (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D18762
To: GeeXT, jgrulich, apol, dfaure, #frameworks
Cc: kde-f
apol added a comment.
Thanks!
Can you land the patch or should we do it for you?
REPOSITORY
R241 KIO
BRANCH
flatpak_open_url (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D18762
To: GeeXT, jgrulich, apol, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, n
GeeXT updated this revision to Diff 52163.
GeeXT added a comment.
Swap the conditions
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18762?vs=51047&id=52163
BRANCH
flatpak_open_url (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D18762
GeeXT marked an inline comment as done.
REPOSITORY
R241 KIO
BRANCH
flatpak_open_url (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D18762
To: GeeXT, jgrulich, apol, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Overall, it looks good to me. Let's get this in.
Regarding your process, I think you could have passed `--devel` on the step 7
and compiled kio there together with konversation. Maybe that
GeeXT added a comment.
Ping?
Btw, I couldn't find any usages of setEnableExternalBrowser in BrowserRun or
KonqRun but there is an usage after instantiating an object of KonqRun (in
KonqMainWindow::openUrl). It's strange that a caller must call the function
itself or it will crash...
REPOS
GeeXT updated this revision to Diff 51047.
GeeXT added a comment.
Add check for external browser enablement status
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18762?vs=51017&id=51047
BRANCH
flatpak_open_url (branched from master)
REVISION DETAIL
https:
dfaure added a comment.
This should only be done if KRun::setEnableExternalBrowser(false) wasn't
called, otherwise it will break KParts' BrowserRun subclass and Konqueror's
KonqRun (who use KRun to actually find out the mimetype of the file, not to
launch another browser).
T
his means ad
GeeXT updated this revision to Diff 51017.
GeeXT added a comment.
The result should be negated
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18762?vs=50972&id=51017
BRANCH
flatpak_open_url (branched from master)
REVISION DETAIL
https://phabricator.kde.or
jgrulich added a comment.
Looks good from the portal point of view, but I would rather wait for someone
who knows KRun internally to approve this review.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18762
To: GeeXT, jgrulich, apol, dfaure, #frameworks
Cc: kde-framewo
ngraham added reviewers: apol, dfaure, Frameworks.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18762
To: GeeXT, jgrulich, apol, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
GeeXT updated this revision to Diff 50972.
GeeXT added a comment.
Restored the accidentally deleted empty line...
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18762?vs=50968&id=50972
BRANCH
flatpak_open_url (branched from master)
REVISION DETAIL
https:/
GeeXT created this revision.
GeeXT added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GeeXT requested review of this revision.
REVISION SUMMARY
Currently KRun in Flatpak/Snap doesn't support portals so it can't launch an
application
15 matches
Mail list logo