D18768: Extend Open Document thumbnailer to Office Open XML
broulik updated this revision to Diff 51173. broulik added a comment. - Read thumbnail location from `rels` - Add `.xps` file format (used in Windows for printing, I believe) which also follows the spec and qualifies as "office document" REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18768?vs=50981=51173 REVISION DETAIL https://phabricator.kde.org/D18768 AFFECTED FILES thumbnail/opendocumentcreator.cpp thumbnail/opendocumentthumbnail.desktop To: broulik, #plasma, #vdg, #frameworks, davidedmundson Cc: davidedmundson, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D18768: Extend Open Document thumbnailer to Office Open XML
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. It seems we can get the correct path via the _rels file as per https://en.wikipedia.org/wiki/Open_Packaging_Conventions which avoids guessing, and allows us to support more file formats in one go REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18768 To: broulik, #plasma, #vdg, #frameworks, davidedmundson Cc: davidedmundson, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D18768: Extend Open Document thumbnailer to Office Open XML
acrouthamel added a comment. Thanks for expanding the thumbnailer lately, awesome work with this and the eBook one. :) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18768 To: broulik, #plasma, #vdg, #frameworks Cc: acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D18768: Extend Open Document thumbnailer to Office Open XML
broulik created this revision. broulik added reviewers: Plasma, VDG, Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This tries to extract the `docProps/thumbnail.*` from `.docx`, `.xlsx`, `.pptx` as well as their templates. TEST PLAN I found that a few of my newer `.docx` most `.pptx` actually contain a `docProps/thumbnail.jpeg` file we can extract. The samples I have are quite small, so please give it a try if you deal with those file types. Internet suggests it can also be `thumbnail.jpg` and `thmbnail.emf` (if Qt can even read that..) so the path isn't hardcoded for those. The thumbnailer library name is kept to avoid changes when user updates and both do have "open" in the name :) I just dropped the Open Document Files suffix REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18768 AFFECTED FILES thumbnail/opendocumentcreator.cpp thumbnail/opendocumentthumbnail.desktop To: broulik, #plasma, #vdg, #frameworks Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
