D18793: Handle text completion with block selection mode

ahmadsamir added a comment. In D18793#437220 , @cullmann wrote: > Hi, I still don't like that we do different things in replaceText depending on the selection of the potential activeView, that makes this function harder to use correctly, as it

D18793: Handle text completion with block selection mode

loh.tar added a comment. In D18793#421367 , @ahmadsamir wrote: > In D18793#420599 , @loh.tar wrote: > > > Fix this patch also Bug 382213 ? > > > No, it doesn't fix it. But this may

D18793: Handle text completion with block selection mode

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Hi, I still don't like that we do different things in replaceText depending on the selection of the potential activeView, that makes this function harder to use correctly, as

D18793: Handle text completion with block selection mode

ahmadsamir added a subscriber: loh.tar. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18793 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, mwolff Cc: loh.tar, kde-frameworks-devel, kwrite-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking,

D18793: Handle text completion with block selection mode

ahmadsamir updated this revision to Diff 54150. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir removed a reviewer: KDevelop. ahmadsamir removed subscribers: loh.tar, mwolff. ahmadsamir added a comment. Verbatim REPOSITORY R39

D18793: Handle text completion with block selection mode

ahmadsamir updated this revision to Diff 54149. ahmadsamir added a comment. - Split the code responsible for inserting text in block selection from typeChars() to a new function - Don't add words where the block selection cursor is inside to the possible completion matches from the

D18793: Handle text completion with block selection mode

ahmadsamir added a comment. In D18793#424628 , @cullmann wrote: > I don't like the change to call typeChars. > > 1. that needs a valid view, activeView() might be null. > 2. replaceText is not interactive per-default, but typeChars is. >

D18793: Handle text completion with block selection mode

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I don't like the change to call typeChars. 1. that needs a valid view, activeView() might be null. 2. replaceText is not interactive per-default, but typeChars is.

D18793: Handle text completion with block selection mode

ahmadsamir added a comment. Do we still need a unit test for this? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18793 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, mwolff Cc: loh.tar, mwolff, kde-frameworks-devel, kwrite-devel, #ktexteditor,

D18793: Handle text completion with block selection mode

ahmadsamir added a comment. In D18793#420599 , @loh.tar wrote: > Fix this patch also Bug 382213 ? No, it doesn't fix it. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18793 To: ahmadsamir, #ktexteditor,

D18793: Handle text completion with block selection mode

loh.tar added a comment. Fix this patch also Bug 382213 ? - do not do auto-brackets when block mode is enabled Well, bad title/request. I would expect that each line get the bracket. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18793 To: ahmadsamir,

D18793: Handle text completion with block selection mode

ahmadsamir added a comment. I changed the diff to make replaceText handle inserting the word completion text. Is this a new behaviour? it exactly matches what users expect when they type something in block selection mode. Also why would this be opt-in? if you type something in

D18793: Handle text completion with block selection mode

ahmadsamir updated this revision to Diff 52658. ahmadsamir added a comment. Change replaceText to handle inserting word completion with block selection mode REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18793?vs=51051=52658 BRANCH

D18793: Handle text completion with block selection mode

mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. we override execution in our own completion models, so this patch will only change the behavior for the builtin word and keyword completion models in ktexteditor I believe

D18793: Handle text completion with block selection mode

ahmadsamir added a comment. Ping? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18793 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop Cc: kde-frameworks-devel, kwrite-devel, #ktexteditor, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars,

D18793: Handle text completion with block selection mode

cullmann added a reviewer: KDevelop. cullmann added a comment. KDevelop uses the completion extensively, perhaps there is some opinion about this change. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18793 To: ahmadsamir, #ktexteditor, cullmann, dhaumann,

D18793: Handle text completion with block selection mode

ahmadsamir created this revision. ahmadsamir added reviewers: KTextEditor, cullmann, dhaumann. Herald added projects: Kate, Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Handle text completion with block selection mode BUG: 359763 FIXED-IN: 5.56 TEST PLAN