D18849: [KPropertiesDialog] Fix group combobox

2019-02-18 Thread Christoph Feck 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:2bba2c0795d7: [KPropertiesDialog] Fix group combobox 
(authored by cfeck).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18849?vs=51180&id=52017

REVISION DETAIL
  https://phabricator.kde.org/D18849

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: cfeck, #frameworks, #dolphin, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18849: [KPropertiesDialog] Fix group combobox

2019-02-08 Thread Kai Uwe Broulik 
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18849

To: cfeck, #frameworks, #dolphin, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18849: [KPropertiesDialog] Fix group combobox

2019-02-08 Thread Christoph Feck 
cfeck created this revision.
cfeck added reviewers: Frameworks, Dolphin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cfeck requested review of this revision.

REVISION SUMMARY
  `groupList` was never initialized with `KUser::groupNames()`, causing the 
subsequent combobox setup to be skipped.
  
  BUG: 403074

TEST PLAN
  `kpropertiesdialogtest` shows a combobox with `users` and `audio` groups on 
my system. Without this patch, no combobox appears.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18849

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: cfeck, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns