D18907: Handle the case if createSpeller is passed an unavailable language

This revision was automatically updated to reflect the committed changes. Closed by commit R246:f49e7a6fb88c: Handle the case if createSpeller is passed an unavailable language (authored by ahmadsamir, committed by cullmann). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE

D18907: Handle the case if createSpeller is passed an unavailable language

ahmadsamir added a comment. I don't have commit access, so please commit the diff. Thanks. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18907 To: ahmadsamir, sandsmark, cullmann, dhaumann Cc: dhaumann, cullmann, loh.tar, kde-frameworks-devel, michaelh,

D18907: Handle the case if createSpeller is passed an unavailable language

ahmadsamir updated this revision to Diff 51578. ahmadsamir added a comment. Avoid shorthand in api docs REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18907?vs=51552=51578 REVISION DETAIL https://phabricator.kde.org/D18907 AFFECTED FILES

D18907: Handle the case if createSpeller is passed an unavailable language

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, thought lang ist still lang. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18907 To: ahmadsamir, sandsmark, cullmann, dhaumann Cc: dhaumann, cullmann,

D18907: Handle the case if createSpeller is passed an unavailable language

ahmadsamir updated this revision to Diff 51552. ahmadsamir added a comment. Improve api docs. Use constFind() with languageClients, as that's more efficient than searching two separate data structures. REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE

D18907: Handle the case if createSpeller is passed an unavailable language

ahmadsamir added a comment. In D18907#410973 , @cullmann wrote: > I think the const at the end for the signal is not wanted, otherwise, this seems to make sense for me. The **this** pointer of Loader::createSpeller is const, so the

D18907: Handle the case if createSpeller is passed an unavailable language

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think the const at the end for the signal is not wanted, otherwise, this seems to make sense for me. I would appreciate a comment what the "lang" param is and that

D18907: Handle the case if createSpeller is passed an unavailable language

ahmadsamir created this revision. ahmadsamir added reviewers: sandsmark, cullmann, dhaumann. ahmadsamir added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY In Loader::createSpeller, retun early if lang isn't one of the available languages(); otherwise a