D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

This revision was automatically updated to reflect the committed changes. Closed by commit R39:598b6c9ca58b: katetextbuffer: refactor TextBuffer::save() to better separate code paths (authored by mgerstner, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

cullmann added a comment. Thanks, will apply this. Nice that you help to improve this code. REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking,

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

mgerstner added a comment. >> @cullmann wrote: > > If you pass me your author email, I will push that. Sure, it's matthias.gerst...@suse.de REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt Cc: kwrite-devel,

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

cullmann added a comment. If you pass me your author email, I will push that. REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann,

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks, other things looks reasonable to me. REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt Cc: kwrite-devel,

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

mgerstner updated this revision to Diff 51951. mgerstner added a comment. Use a C++11 enum class with KDE style CamelCase identifiers. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19001?vs=51662=51951 REVISION DETAIL https://phabricator.kde.org/D19001 AFFECTED FILES

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

dhaumann added a comment. In D19001#413694 , @cullmann wrote: > This looks reasonable, but could we get some Qt/KDE style CamelCase enum values? > > enum SaveResult { > > SAVE_FAILED = 0, > SAVE_NO_PERMS, >

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. This looks reasonable, but could we get some Qt/KDE style CamelCase enum values? enum SaveResult { SAVE_FAILED = 0, SAVE_NO_PERMS, SAVE_SUCCESS

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

ngraham added reviewers: chinmoyr, fvogt. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars,

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

lbeltrame added reviewers: dhaumann, cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

lbeltrame added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

mgerstner created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. mgerstner requested review of this revision. REVISION SUMMARY This change breaks up the rather large `TextBuffer::save()` into separate functions. Most