bruns marked an inline comment as done.
bruns added inline comments.
INLINE COMMENTS
> lbeltrame wrote in externalextractor.cpp:120
> Will this block anything?
At most 3 seconds (non gui task), also see the waitforfinished below ...
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://pha
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:36dafc3cb668: [ExternalExtractor] Provide more helpful
output when extractor fails (authored by bruns).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19108?v
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
LGTM!. Annoyed me for a long time (and made hard to debug some issues).
INLINE COMMENTS
> externalextractor.cpp:120
> extractorProcess.start(d->mainPath, QStringList(), QIODevice
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
In case the executable fails to start, no error
