D19198: BrightScript: Unary and hex numbers, @attribute

2019-02-21 Thread Daniel Levin
dlevin added a comment.


  Thanks for cleaning up the tests after me!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19198

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann


D19198: BrightScript: Unary and hex numbers, @attribute

2019-02-21 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:5c0f50026bfc: BrightScript: Unary and hex numbers, 
@attribute (authored by dlevin, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19198?vs=52195=52199

REVISION DETAIL
  https://phabricator.kde.org/D19198

AFFECTED FILES
  autotests/html/brightscript.brs.html
  autotests/input/brightscript.brs
  autotests/reference/brightscript.brs.ref
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann


D19198: BrightScript: Unary and hex numbers, @attribute

2019-02-21 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks reasonable + we have a test => nice, merging.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19198

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann


D19198: BrightScript: Unary and hex numbers, @attribute

2019-02-21 Thread Daniel Levin
dlevin created this revision.
dlevin added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dlevin requested review of this revision.

REVISION SUMMARY
  Fixed small issues for rvalue highlighting:
  
  - Unary numbers, prefixed with +-
  - Hex numbers, prefixed with 
  - Attribute dereference with var@attr syntax

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19198

AFFECTED FILES
  autotests/html/brightscript.brs.html
  autotests/input/brightscript.brs
  autotests/reference/brightscript.brs.ref
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann