D19215: Install DefinitionDownloader header
This revision was automatically updated to reflect the committed changes. Closed by commit R216:df18fada76b2: Install DefinitionDownloader header (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19215?vs=52269&id=52478 REVISION DETAIL https://phabricator.kde.org/D19215 AFFECTED FILES src/lib/CMakeLists.txt To: davschul, cullmann, vkrause Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars
D19215: Install DefinitionDownloader header
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19215 To: davschul, cullmann, vkrause Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars
D19215: Install DefinitionDownloader header
dhaumann added a comment. I also do not see an issue with this. But I would like to add some background info that may be interesting: Downloading the syntax highlighting files will download all files, and not just the ones that changed etc. This by itself is fine, since it guarantees consistency with highlighting files that include each other with the IncludeRules rule. However, with downloading you'll get almost 300 .xml files that need to be checked for version info etc... That may be slow (and in fact one of the reasons why we compile in the files as Qt resource). That said, if you open a file that uses KSyntaxHighlighting, you may experience several hundred milliseconds of delay when the Repository instance is created. I am just adding this as a "you should know what you are doing" info, since you probably want to avoid instanciating a Repository by default on application startup, since then Qt Creator would startup slower. Besides that, no issues from my side, of course :-) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19215 To: davschul, cullmann, vkrause Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars
D19215: Install DefinitionDownloader header
cullmann added a comment. I would have no issues with this if Volker is ok, too. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19215 To: davschul, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D19215: Install DefinitionDownloader header
davschul created this revision. davschul added reviewers: cullmann, vkrause. davschul added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davschul requested review of this revision. REVISION SUMMARY Makes it possible to use the exported definition downloader from an installed syntax highlighting engine. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19215 AFFECTED FILES src/lib/CMakeLists.txt To: davschul, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
