D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

ngraham added a comment. I'm wondering if this really needs to be configurable, and if it really needs to exist as described here. Maybe what would make more sense is to always show whitespace characters for the current/selected line even if the current option is off. Then when the

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

cullmann added a subscriber: ngraham. cullmann added a comment. At the moment we have one combobox "Whitespaces" and one checkbox "Highlight tabulators" in "Whitespace Highlighting". I thought one wanted now to collapse/change that into 1-2 comboboxes ;=) Perhaps it would be better

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

loh.tar added a comment. > What would be the concrete content of the combobox then? What? Which box? These box can became these 4th "Smart" option but the code should then only work on spacesto be "correct/right". How about one extra bool which covers all normaly hidden stuff to

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

cullmann added a comment. Ah, you mean because of the "show tabs" extra option, yeah, forgot that :/ What would be the concrete content of the combobox then? REVISION DETAIL https://phabricator.kde.org/D19254 To: loh.tar, #ktexteditor Cc: cullmann, dhaumann, kwrite-devel,

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

loh.tar added a comment. > Given we already have now some enum for the show spaces stuff (None/Trailing/All) I would just vote to have some "Smart" 4th variant inside Can do, but this combobox reads to me for true spaces only, no tabs. See also Dominiks comment

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

cullmann added a comment. I think this feature is nice. Given we already have now some enum for the show spaces stuff (None/Trailing/All) I would just vote to have some "Smart" 4th variant inside. We can later tweak this "Smart" variant like we want it to behave, actually the "always

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

meven edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D19254 To: loh.tar, #ktexteditor Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

loh.tar updated this revision to Diff 56110. loh.tar added a comment. - Rebase on master to keep it compile - Not further investigated if changes by D19163 needs more tweeks here > PS: Better naming for foobar ? :-) Yes :-) > I think this

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

dhaumann added a comment. I think this, since it removes visual clutter. I think this should be configurable... Question is how to properly add an option in the config widget, since in the code I can see that this feature changes several options: tabs + trailing spaces + nonprintable

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY The original bug says: Show tabs and space characters only on