D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

[Christoph Roick]

croick added a comment.


  In D19420#460766 , @apol wrote:
  
  > Looks good to me, have you checked that it's now not breaking what @broulik 
found?
  
  
  Yes, I tested loading systemsettings.svg 
(`/usr/share/icons/breeze/apps/48/systemsettings.svg`) by using #kate 
 and renaming the suffix to `.svgz`. 
With my previous commit 96083005e90e 
, 
the file would not be loaded entirely. Using this patch, all of the file is 
loaded.
  I don't compile plasma myself, so I didn't check whether the icons are 
displayed now. But the reason for not rendering the icons is gone.

REVISION DETAIL
  https://phabricator.kde.org/D19420

To: croick, broulik, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

[Aleix Pol Gonzalez]

apol added a comment.


  Looks good to me, have you checked that it's now not breaking what @broulik 
found?

REVISION DETAIL
  https://phabricator.kde.org/D19420

To: croick, broulik, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

[Christoph Roick]

croick added a comment.


  In D19420#441163 , @croick wrote:
  
  > Would you accept now @apol?
  
  
  Or now?

REVISION DETAIL
  https://phabricator.kde.org/D19420

To: croick, broulik, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

[Christoph Roick]

croick added a comment.


  Would you accept now @apol?

REVISION DETAIL
  https://phabricator.kde.org/D19420

To: croick, broulik, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

[Christoph Roick]

croick added a comment.


  In D19420#422043 , @apol wrote:
  
  > With a unit test it would be much easier to accept the patch ;)
  
  
  ... and to identify a remaining bug.
  The header is now read again after re-initialization.

REVISION DETAIL
  https://phabricator.kde.org/D19420

To: croick, broulik, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

[Christoph Roick]

croick updated this revision to Diff 52868.
croick added a comment.


  add unit test, reset bNeedHeader

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19420?vs=52825=52868

REVISION DETAIL
  https://phabricator.kde.org/D19420

AFFECTED FILES
  autotests/data/noop_big.gz
  autotests/data/noop_small.gz
  autotests/kfiltertest.cpp
  autotests/kfiltertest.h
  src/kcompressiondevice.cpp
  src/kgzipfilter.cpp

To: croick, broulik, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

[Aleix Pol Gonzalez]

apol added a comment.


  With a unit test it would be much easier to accept the patch ;)

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D19420

To: croick, broulik, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

[Kai Uwe Broulik]

broulik added a comment.


  Works fine here, thanks, but I don't feel qualified enough to comment on this 
patch, I added Frameworks reviewers.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D19420

To: croick, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

[Kai Uwe Broulik]

broulik added a reviewer: Frameworks.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D19420

To: croick, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

[Christoph Roick]

croick created this revision.
croick added a reviewer: broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
croick requested review of this revision.

REVISION SUMMARY
  - return KFilterBase::End if KGzipFilter::uncompress_noop() finished reading
  - reset result to KFilterBase::Ok if there is data remaining
  - fixes 96083005e90e 


TEST PLAN
  - load gzipped files (size < and > than BUFFER_SIZE = 8192 bytes) using kate 
and labplot
  - load unzipped files with .gz suffix (size < and > than 8192 bytes) using 
kate and labplot
  - load bzipped files with kate

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D19420

AFFECTED FILES
  src/kcompressiondevice.cpp
  src/kgzipfilter.cpp

To: croick, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns