D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

andreask added a comment. I had choose also an tooltip like most other apps do and there it work very well. F6740005: libreoffice-password-content.png REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19512 To: loh.tar,

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

This revision was automatically updated to reflect the committed changes. Closed by commit R39:186b4858818c: KateStatusBar: Show lock icon on modified label when in read-only mode (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok with this change. You can commit yourself now, or? REVISION DETAIL https://phabricator.kde.org/D19512 To: loh.tar, #ktexteditor, cullmann Cc: ngraham, cullmann, kwrite-devel,

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

loh.tar added a comment. Regarding icon, tooltip and save action, see also https://phabricator.kde.org/D17730#392331 REVISION DETAIL https://phabricator.kde.org/D19512 To: loh.tar, #ktexteditor, cullmann Cc: ngraham, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad,

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

loh.tar updated this revision to Diff 53253. loh.tar added a comment. - Use signal KTextEditor::DocumentPrivate::readWriteChanged to update icon CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19512?vs=53123=53253 REVISION DETAIL https://phabricator.kde.org/D19512 AFFECTED FILES

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

cullmann added a comment. In D19512#425307 , @ngraham wrote: > Tooltips are used throughout KDE and are approved by our HIG. We can use one here. I am not sure if tooltips are that great in the status bar. You often hover over that

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

ngraham added a comment. Tooltips are used throughout KDE and are approved by our HIG. We can use one here. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19512 To: loh.tar, #ktexteditor, cullmann Cc: ngraham, cullmann, kwrite-devel, kde-frameworks-devel,

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

loh.tar added a comment. > Semi-relatedly: can we make this little bottom-left corner icon not not have a hover effect if it's not clickable, and have a tooltip when you hover over it so you can figure out what it means? It appeared recently and I found myself very confused by it due to

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

ngraham added a comment. Semi-relatedly: can we make this little bottom-left corner icon not not have a hover effect if it's not clickable, and have a tooltip when you hover over it so you can figure out what it means? It appeared recently and I found myself very confused by it due to those

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think the lock icon won't hurt. For the implementation: isn't it enough to watch for the readWriteChanged(...) signal of the document and trigger the modifiedChanged()

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY This may not needed because the information is already shown