D19557: Update css

ltoscano added a comment. In D19557#428619 , @ognarb wrote: > In D19557#428618 , @ltoscano wrote: > > > In D19557#428617 , @ognarb wrote: > > > > > The

D19557: Update css

ognarb added a comment. In D19557#428618 , @ltoscano wrote: > In D19557#428617 , @ognarb wrote: > > > They use the old link for the image, also the jpg version instead of the png. I tested with new p

D19557: Update css

ltoscano added a comment. In any case, please change the commit message. When this is committed and rechecked in one year from now, the aspect of the linked website may not be relevant anymore and the images are not visible when you run git log. Please describe what the change is about. ht

D19557: Update css

ltoscano added a comment. In D19557#428617 , @ognarb wrote: > They use the old link for the image, also the jpg version instead of the png. I tested with new page and old page and the result is visually the same. But do the existing pages

D19557: Update css

ognarb added a comment. In D19557#428614 , @ltoscano wrote: > No, wait a minute. What happens with pages which are not regenerated? They use the old link for the image, also the jpg version instead of the png. I tested with new page and o

D19557: Update css

ltoscano requested changes to this revision. ltoscano added a comment. This revision now requires changes to proceed. No, wait a minute. What happens with pages which are not regenerated? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #docu

D19557: Update css

ltoscano accepted this revision. ltoscano added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation, yurchor, ltoscano Cc: yurchor, rooty, ltoscan

D19557: Update css

ognarb updated this revision to Diff 53603. ognarb added a comment. Don't change image size REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53598&id=53603 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES com

D19557: Update css

ltoscano requested changes to this revision. ltoscano added a comment. This revision now requires changes to proceed. Can you please not overwrite top-kde.jpg too, or at least use the same size? Because the change of size may be a problem for existing users (if any, but I consider those files

D19557: Update css

yurchor accepted this revision. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation, yurchor Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, kde-framework

D19557: Update css

ognarb updated this revision to Diff 53598. ognarb added a comment. - Add deleted image - Rename top-kde.png to kde.png - Fix strange margin issues for some elements @rooty The font can be changed in the khelpcenter settings. But it's strange that it doesn't use Plasma settings per de

D19557: Update css

yurchor added a comment. In D19557#428394 , @ltoscano wrote: > Apart from the VDG, I'm sure that @yurchor can give some hints, as he manages the templates used to generate the PDFs. I have no objections. This part is not used for PDFs, bt

D19557: Update css

ltoscano added a subscriber: yurchor. ltoscano added a comment. On the graphical side I'm not the most qualified to talk :) Apart from the VDG, I'm sure that @yurchor can give some hints, as he manages the templates used to generate the PDFs. From the technical point of view, I wouldn't

D19557: Update css

rooty added a comment. Can you make it use Noto Sans by any chance? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: rooty, ltoscano, bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh,

D19557: Update css

aacid added a subscriber: ltoscano. aacid added a comment. @ognarb i don't really have much to say here, my comment was just about a new file being introduced that seemed unnecessary. I'd say you want @ltoscano for someone that probably knows a bit about docs.kde.org code and maybe someo

D19557: Update css

ognarb updated this revision to Diff 53546. ognarb added a comment. Apply optipng. Thanks @bruns I learned something new :D. REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53545&id=53546 BRANCH master REVISION DETAIL https://phabricator.kde

D19557: Update css

bruns added a comment. and now, apply optipng and you are down to 2kB REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadin

D19557: Update css

ognarb updated this revision to Diff 53545. ognarb added a comment. Use inkscape to generate png REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53544&id=53545 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

bruns added a comment. In D19557#428096 , @ognarb wrote: > Lol 128x128 png image 6kb, 129x129 png image 2kb The new PNG is fuzzy, thats probably the reason it does not compress well. Try exporting it with inkscape, and check if the ve

D19557: Update css

ognarb added a comment. Lol 128x128 png image 6kb, 129x129 png image 2kb REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, ska

D19557: Update css

ognarb updated this revision to Diff 53544. ognarb added a comment. Use a 128x128 png image REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53542&id=53544 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES com

D19557: Update css

ognarb added a comment. In D19557#428086 , @bruns wrote: > Is it intentional the PNG is 129x129 while the JPEG is 128x128? I have no idea why 129x129. I used `convert` to convert the svg to png, just like I did with the jpg. But I will in

D19557: Update css

bruns added a comment. Is it intentional the PNG is 129x129 while the JPEG is 128x128? Also, the JPEG shold be removed. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel,

D19557: Update css

ognarb updated this revision to Diff 53542. ognarb added a comment. Change png image REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53541&id=53542 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES common/en/

D19557: Update css

ognarb updated this revision to Diff 53541. ognarb added a comment. Use png instead of jpg REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53521&id=53541 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES comm

D19557: Update css

bruns added a comment. In D19557#426051 , @aacid wrote: > Why changing from jpg to png for the image file ? The logo is just 2 colors, and the PNG is smaller than the JPEG, without introducing artifacts. I would definitely prefer a PNG he

D19557: Update css

ognarb added a comment. @aacid it is ready to land? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb updated this revision to Diff 53521. ognarb added a comment. Use correct breeze color for important and warning REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53469&id=53521 BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D19557: Update css

ognarb updated this revision to Diff 53469. ognarb added a comment. Improve display inline media REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53367&id=53469 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

abetts added a comment. +1 REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb updated this revision to Diff 53367. ognarb added a comment. Add breeze like style for note/info/warning/tip admonitions and make image responsive REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53359&id=53367 BRANCH master REVISION DE

D19557: Update css

ognarb updated this revision to Diff 53359. ognarb edited the test plan for this revision. ognarb added a comment. Change to jpg and remove now useless files REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53251&id=53359 BRANCH master REVISION

D19557: Update css

ognarb added a comment. In D19557#426051 , @aacid wrote: > Why changing from jpg to png for the image file ? I only had a png version in my hard drive, but if it's a problem I can convert the png in a jpg. In D19557#426057

D19557: Update css

broulik added a comment. Can't we just go SVG with the icon? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

aacid added a comment. Why changing from jpg to png for the image file ? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb edited the summary of this revision. ognarb edited the test plan for this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb added reviewers: VDG, Documentation. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Header look like http://docs.carlschwan.eu/ Screenshot comming TEST PLAN Wasn't able