D19557: Update css

[Luigi Toscano]

ltoscano added a comment.


  In D19557#428619 , @ognarb wrote:
  
  > In D19557#428618 , @ltoscano 
wrote:
  >
  > > In D19557#428617 , @ognarb 
wrote:
  > >
  > > > They use the old link for the image, also the jpg version instead of 
the png. I tested with new page and old page and the result is visually the 
same.
  > >
  > >
  > > But do the existing pages use the old link for the image with the new CSS?
  >
  >
  > Yes the link to the css didn't change, only the content. So even the old 
page links to the new CSS.
  
  
  Ok, so let's back one minute, and maybe it was the case in the original 
review, despite what myself and other people suggested, what if:
  
  - the changes to the XSL files are reverted
  - top-kde.jpg is rewritten using the same size of the original, and of course 
same format. No need to add the new kde.png. You may want to add it, but same 
format, so that we can switch in KF6.
  
  This should ensure no unexpected changes if any user expect the image to be 
that size, and both newly-generated pages and the old ones will have the same 
aspect.
  
  Sorry if it was the case in the first review.
  
  The point about the commit message is still valid.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb added a comment.


  In D19557#428618 , @ltoscano wrote:
  
  > In D19557#428617 , @ognarb wrote:
  >
  > > They use the old link for the image, also the jpg version instead of the 
png. I tested with new page and old page and the result is visually the same.
  >
  >
  > But do the existing pages use the old link for the image with the new CSS?
  
  
  Yes the link to the css didn't change, only the content. So even the old page 
links to the new CSS.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Luigi Toscano]

ltoscano added a comment.


  In any case, please change the commit message. When this is committed and 
rechecked in one year from now, the aspect of the linked website may not be 
relevant anymore and the images are not visible when you run git log.
  Please describe what the change is about. 
https://chris.beams.io/posts/git-commit/

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Luigi Toscano]

ltoscano added a comment.


  In D19557#428617 , @ognarb wrote:
  
  > They use the old link for the image, also the jpg version instead of the 
png. I tested with new page and old page and the result is visually the same.
  
  
  But do the existing pages use the old link for the image with the new CSS?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb added a comment.


  In D19557#428614 , @ltoscano wrote:
  
  > No, wait a minute. What happens with pages which are not regenerated?
  
  
  They use the old link for the image, also the jpg version instead of the png. 
I tested with new page and old page and the result is visually the same.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Luigi Toscano]

ltoscano requested changes to this revision.
ltoscano added a comment.
This revision now requires changes to proceed.


  No, wait a minute. What happens with pages which are not regenerated?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Luigi Toscano]

ltoscano accepted this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53603.
ognarb added a comment.


  Don't change image size

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53598=53603

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/top-kde.jpg
  src/customization/kde-navig-online.xsl
  src/customization/kde-navig.xsl

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Luigi Toscano]

ltoscano requested changes to this revision.
ltoscano added a comment.
This revision now requires changes to proceed.


  Can you please not overwrite top-kde.jpg too, or at least use the same size? 
Because the change of size may be a problem for existing users (if any, but I 
consider those files as part of the public interface of KDocTools

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Yuri Chornoivan]

yurchor accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53598.
ognarb added a comment.


  - Add deleted image
  - Rename top-kde.png to kde.png
  - Fix strange margin issues for some elements
  
  @rooty The font can be changed in the khelpcenter settings. But it's strange 
that it doesn't use Plasma settings per default.

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53546=53598

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/top-kde.jpg
  src/customization/kde-navig-online.xsl
  src/customization/kde-navig.xsl

To: ognarb, #vdg, #documentation
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Yuri Chornoivan]

yurchor added a comment.


  In D19557#428394 , @ltoscano wrote:
  
  > Apart from the VDG, I'm sure that @yurchor can give some hints, as he 
manages the templates used to generate the PDFs.
  
  
  I have no objections. This part is not used for PDFs, btw. ;)

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Luigi Toscano]

ltoscano added a subscriber: yurchor.
ltoscano added a comment.


  On the graphical side I'm not the most qualified to talk :)
  Apart from the VDG, I'm sure that @yurchor can give some hints, as he manages 
the templates used to generate the PDFs.
  
  From the technical point of view, I wouldn't remove any of the exiting files 
right now, at least not until KF6. I'd suggest using new names, just to avoid 
the possible confusion between the old top-kde.jpg and the new top-kde.png.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Krešimir Čohar]

rooty added a comment.


  Can you make it use Noto Sans by any chance?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: rooty, ltoscano, bruns, abetts, broulik, aacid, kde-frameworks-devel, 
kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Albert Astals Cid]

aacid added a subscriber: ltoscano.
aacid added a comment.


  @ognarb i don't really have much to say here, my comment was just about a new 
file being introduced that seemed unnecessary.
  
  I'd say you want @ltoscano for someone that probably knows a bit about 
docs.kde.org code and maybe someone from VDG to say if it's prettier than 
before?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: ltoscano, bruns, abetts, broulik, aacid, kde-frameworks-devel, 
kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53546.
ognarb added a comment.


  Apply optipng. Thanks @bruns I learned something new :D.

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53545=53546

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/kde_logo_bg.png
  common/en/top-kde.jpg
  common/en/top-kde.png
  common/en/top-left.jpg
  common/en/top-right.jpg
  common/en/top.jpg
  src/customization/kde-navig-online.xsl
  src/customization/kde-navig.xsl

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Stefan Brüns]

bruns added a comment.


  and now, apply optipng and you are down to 2kB

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53545.
ognarb added a comment.


  Use inkscape to generate png

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53544=53545

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/kde_logo_bg.png
  common/en/top-kde.jpg
  common/en/top-kde.png
  common/en/top-left.jpg
  common/en/top-right.jpg
  common/en/top.jpg
  src/customization/kde-navig-online.xsl
  src/customization/kde-navig.xsl

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Stefan Brüns]

bruns added a comment.


  In D19557#428096 , @ognarb wrote:
  
  > Lol 128x128 png image 6kb, 129x129 png image 2kb
  
  
  The new PNG is fuzzy, thats probably the reason it does not compress well.
  
  Try exporting it with inkscape, and check if the vertical/horizontal edges 
are pixel grid aligned.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb added a comment.


  Lol 128x128 png image 6kb, 129x129 png image 2kb

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53544.
ognarb added a comment.


  Use a 128x128 png image

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53542=53544

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/kde_logo_bg.png
  common/en/top-kde.jpg
  common/en/top-kde.png
  common/en/top-left.jpg
  common/en/top-right.jpg
  common/en/top.jpg
  src/customization/kde-navig-online.xsl
  src/customization/kde-navig.xsl

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb added a comment.


  In D19557#428086 , @bruns wrote:
  
  > Is it intentional the PNG is 129x129 while the JPEG is 128x128?
  
  
  I have no idea why 129x129. I used `convert` to convert the svg to png, just 
like I did with the jpg. But I will investigate this issue
  
  > Also, the JPEG shold be removed.
  
  I'm not sure, but I think this will be a problem with some documentations 
where the html wasn't regenerated, because the html wasn't regenerated the 
image element will link to a deadlink.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Stefan Brüns]

bruns added a comment.


  Is it intentional the PNG is 129x129 while the JPEG is 128x128?
  Also, the JPEG shold be removed.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53542.
ognarb added a comment.


  Change png image

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53541=53542

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/kde_logo_bg.png
  common/en/top-kde.jpg
  common/en/top-kde.png
  common/en/top-left.jpg
  common/en/top-right.jpg
  common/en/top.jpg
  src/customization/kde-navig-online.xsl
  src/customization/kde-navig.xsl

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53541.
ognarb added a comment.


  Use png instead of jpg

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53521=53541

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/kde_logo_bg.png
  common/en/top-kde.jpg
  common/en/top-kde.png
  common/en/top-left.jpg
  common/en/top-right.jpg
  common/en/top.jpg
  src/customization/kde-navig-online.xsl
  src/customization/kde-navig.xsl

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Stefan Brüns]

bruns added a comment.


  In D19557#426051 , @aacid wrote:
  
  > Why changing from jpg to png for the image file ?
  
  
  The logo is just 2 colors, and the PNG is smaller than the JPEG, without 
introducing artifacts. I would definitely prefer a PNG here.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, 
gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb added a comment.


  @aacid it is ready to land?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, 
michaelh, ngraham, bruns, skadinna

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53521.
ognarb added a comment.


  Use correct breeze color for important and warning

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53469=53521

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/kde_logo_bg.png
  common/en/top-kde.jpg
  common/en/top-left.jpg
  common/en/top-right.jpg
  common/en/top.jpg

To: ognarb, #vdg, #documentation
Cc: abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, 
michaelh, ngraham, bruns, skadinna

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53469.
ognarb added a comment.


  Improve display inline media

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53367=53469

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/kde_logo_bg.png
  common/en/top-kde.jpg
  common/en/top-left.jpg
  common/en/top-right.jpg
  common/en/top.jpg

To: ognarb, #vdg, #documentation
Cc: abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, 
michaelh, ngraham, bruns, skadinna

D19557: Update css

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, 
michaelh, ngraham, bruns, skadinna

D19557: Update css

[Carl Schwan]

ognarb edited the summary of this revision.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, 
ngraham, bruns, skadinna

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53367.
ognarb added a comment.


  Add breeze like style for note/info/warning/tip admonitions and make image 
responsive

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53359=53367

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/kde_logo_bg.png
  common/en/top-kde.jpg
  common/en/top-left.jpg
  common/en/top-right.jpg
  common/en/top.jpg

To: ognarb, #vdg, #documentation
Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, 
ngraham, bruns, skadinna

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53359.
ognarb edited the test plan for this revision.
ognarb added a comment.


  Change to jpg and remove now useless files

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53251=53359

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/kde_logo_bg.png
  common/en/top-kde.jpg
  common/en/top-left.jpg
  common/en/top-right.jpg
  common/en/top.jpg

To: ognarb, #vdg, #documentation
Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, 
ngraham, bruns, skadinna

D19557: Update css

[Carl Schwan]

ognarb added a comment.


  In D19557#426051 , @aacid wrote:
  
  > Why changing from jpg to png for the image file ?
  
  
  I only had a png version in my hard drive, but if it's a problem I can 
convert the png in a jpg.
  
  In D19557#426057 , @broulik wrote:
  
  > Can't we just go SVG with the icon?
  
  
  I tried this first but khtml didn't look like it support svg.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, 
ngraham, bruns, skadinna

D19557: Update css

[Kai Uwe Broulik]

broulik added a comment.


  Can't we just go SVG with the icon?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, 
ngraham, bruns, skadinna

D19557: Update css

[Albert Astals Cid]

aacid added a comment.


  Why changing from jpg to png for the image file ?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, 
bruns, skadinna

D19557: Update css

[Carl Schwan]

ognarb edited the summary of this revision.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, 
skadinna

D19557: Update css

[Carl Schwan]

ognarb edited the summary of this revision.
ognarb edited the test plan for this revision.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, 
skadinna

D19557: Update css

[Carl Schwan]

ognarb added reviewers: VDG, Documentation.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, 
skadinna

D19557: Update css

[Carl Schwan]

ognarb edited the summary of this revision.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb
Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, 
skadinna

D19557: Update css

[Carl Schwan]

ognarb created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  Header look like http://docs.carlschwan.eu/
  
  Screenshot comming

TEST PLAN
  Wasn't able to directly run in khelpcenter, so this was run in konqueror with 
khtml activated. Need to be run in khelpcenter to be sure.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/top-kde.png
  src/customization/kde-navig-online.xsl
  src/customization/kde-navig.xsl

To: ognarb
Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, 
skadinna