D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

kossebau added a comment. In D19565#678804 , @alex wrote: > However the option seems pretty unused, even from a github search: https://github.com/search?q=HeaderExtension%3D+extension%3Akcfgc=Code=advsearch== In comparison to how many

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

alex added a comment. However the option seems pretty unused, even from a github search: https://github.com/search?q=HeaderExtension%3D+extension%3Akcfgc=Code=advsearch== > KF targets also consumers outside of KDE spheres Also I think there are currently quite a lot of kcfgc

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

kossebau added a comment. In D19565#678799 , @alex wrote: > I am wondering if there is really a need for it. SourceExtension seems completely unused and HeaderExtension is only used in okteta. > > Though in KDE code, Qt code (and most other

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

alex added a comment. I am wondering if there is really a need for it. SourceExtension seems completely unused and HeaderExtension is only used in okteta. Though in KDE code, Qt code (and most other that I know of) it is the ".h" extension is the most common one for headers. Are

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

This revision was automatically updated to reflect the committed changes. Closed by commit R237:a3ed87ca7808: kconfig_compiler: new kcfgc args HeaderExtension SourceExtension (authored by kossebau). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH configfileextensions REVISION DETAIL https://phabricator.kde.org/D19565 To: kossebau, #frameworks, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

kossebau added a comment. @apol Thanks for review. No further comments anyone? Would then proceed to push this next Monday, March 18th, if no-one objects. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19565 To: kossebau, #frameworks Cc: apol,

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

kossebau updated this revision to Diff 53299. kossebau added a comment. update to latest master REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19565?vs=53273=53299 BRANCH configfileextensions REVISION DETAIL https://phabricator.kde.org/D19565

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

apol added a comment. +1 LGTM REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19565 To: kossebau, #frameworks Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

kossebau updated this revision to Diff 53273. kossebau added a comment. fixup: correct default cpp for SourceExtension in README.dox REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19565?vs=53272=53273 BRANCH configfileextensions REVISION DETAIL

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY When using kconfig_compiler generated sources in projects where the used