D19620: Use a searchbar similar to the one in okular

2019-09-21 Thread Carl Schwan 
ognarb abandoned this revision.
ognarb added a comment.


  I completly forgot about this patch and since KHTML is dead and is getting 
removed from most of our apps, it doesn't makes sence to land this patch.

REPOSITORY
  R313 KHtml

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: dhaumann, GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D19620: Use a searchbar similar to the one in okular

2019-09-21 Thread Nathaniel Graham 
ngraham added a comment.


  Isn't KHTML deprecated at this point? Does this actually need to happen?

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: dhaumann, GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D19620: Use a searchbar similar to the one in okular

2019-09-21 Thread Björn Feber 
GB_2 added a comment.


  Ping.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: dhaumann, GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D19620: Use a searchbar similar to the one in okular

2019-08-17 Thread Björn Feber 
GB_2 added a comment.


  See https://phabricator.kde.org/D19774#inline-110882

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: dhaumann, GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D19620: Use a searchbar similar to the one in okular

2019-08-17 Thread Dominik Haumann 
dhaumann added a comment.


  In D19620#512883 , @GB_2 wrote:
  
  > Don't use the unicode ellipsis. We use three dots everywhere.
  
  
  Interesting. @ngraham didn't you suggest to use the ellipsis recently?

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: dhaumann, GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D19620: Use a searchbar similar to the one in okular

2019-08-16 Thread Björn Feber 
GB_2 added a comment.


  Don't use the unicode ellipsis. We use three dots everywhere.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan 
ognarb updated this revision to Diff 53928.
ognarb added a comment.


  Use Unicode ellipsis

REPOSITORY
  R313 KHtml

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19620?vs=53906=53928

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

AFFECTED FILES
  src/ui/findbar/khtmlfindbar.cpp
  src/ui/findbar/khtmlfindbar_base.ui

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan 
ognarb edited the summary of this revision.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan 
ognarb edited the summary of this revision.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan 
ognarb edited the summary of this revision.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan 
ognarb updated this revision to Diff 53906.
ognarb added a comment.


  Remove icon to option button

REPOSITORY
  R313 KHtml

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19620?vs=53505=53906

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

AFFECTED FILES
  src/ui/findbar/khtmlfindbar.cpp
  src/ui/findbar/khtmlfindbar_base.ui

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-14 Thread Carl Schwan 
ognarb edited the summary of this revision.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-09 Thread Carl Schwan 
ognarb edited the summary of this revision.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-09 Thread Carl Schwan 
ognarb updated this revision to Diff 53505.
ognarb added a comment.


  Add icons

REPOSITORY
  R313 KHtml

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19620?vs=53488=53505

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

AFFECTED FILES
  src/ui/findbar/khtmlfindbar.cpp
  src/ui/findbar/khtmlfindbar_base.ui

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-08 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  Nice work!

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-08 Thread Carl Schwan 
ognarb edited the summary of this revision.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-08 Thread Carl Schwan 
ognarb updated this revision to Diff 53488.
ognarb edited the summary of this revision.
ognarb added a comment.
This revision is now accepted and ready to land.


  Use placeholder text and clearButton

REPOSITORY
  R313 KHtml

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19620?vs=53468=53488

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

AFFECTED FILES
  src/ui/findbar/khtmlfindbar.cpp
  src/ui/findbar/khtmlfindbar_base.ui

To: ognarb, #vdg, #frameworks, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-08 Thread Noah Davis 
ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Yes, I think this is better and it's good to be consistent.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19620: Use a searchbar similar to the one in okular

2019-03-08 Thread Carl Schwan 
ognarb retitled this revision from "Use a searchbar similar to the one from 
okular" to "Use a searchbar similar to the one in okular".

REPOSITORY
  R313 KHtml

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19620: Use a searchbar similar to the one from okular

2019-03-08 Thread Carl Schwan 
ognarb edited the summary of this revision.
ognarb added reviewers: VDG, Frameworks.

REPOSITORY
  R313 KHtml

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19620: Use a searchbar similar to the one from okular

2019-03-08 Thread Carl Schwan 
ognarb created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  Improve consistency between different KDE apps.
  
  It's not perfect (close button isn't aligned).
  
  Screenshot comming :D

TEST PLAN
  Build and tested with konqueror master

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

AFFECTED FILES
  src/ui/findbar/khtmlfindbar_base.ui

To: ognarb
Cc: kde-frameworks-devel, michaelh, ngraham, bruns