D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart abandoned this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D19686 To: mart, #plasma, #frameworks Cc: broulik, ngraham, bruns, fvogt, kde-frameworks-devel, michaelh

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart added a comment. latest version loads again correctly stuff from @2 icon dirs, still, only on integer scaling, as it was doing before (wether that behavior is to be changedis another topic) REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D19686 To: mart,

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart updated this revision to Diff 53740. mart added a comment. - scale the size for lookup on KIconThemePrivate::iconPath REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19686?vs=53727=53740 BRANCH phab/iconRendering REVISION DETAIL

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart updated this revision to Diff 53727. mart added a comment. - don reset the scale that gets passed around REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19686?vs=53670=53727 BRANCH phab/iconRendering REVISION DETAIL

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart added a comment. In D19686#429343 , @broulik wrote: > I'm confused. Doesnt this undo the use of @2x icons and return to the old behavior of just loading a larger icon? hmm, perhaps, so probablythat check is to be done in kiconloader

D19686: don't scale when we are in AA_UseHighDpiPixmaps

broulik added a comment. I'm confused. Doesnt this undo the use of @2x icons and return to the old behavior of just loading a larger icon? REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D19686 To: mart, #plasma, #frameworks Cc: broulik, ngraham, bruns, fvogt,

D19686: don't scale when we are in AA_UseHighDpiPixmaps

ngraham added a comment. Sweet, this makes so many things look a little bit better. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D19686 To: mart, #plasma, #frameworks Cc: ngraham, bruns, fvogt, kde-frameworks-devel, michaelh

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart edited the summary of this revision. mart added a reviewer: Frameworks. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D19686 To: mart, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart added a comment. F6684042: Screenshot_20190311_162844.png F6684047: Screenshot_20190311_164519.png F6684051: Screenshot_20190311_164524.png REPOSITORY R302

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY when the flag AA_UseHighDpiPixmaps is set, the pixmap is already scaled, no need to scale it