This revision was automatically updated to reflect the committed changes.
Closed by commit R241:0ba76d410a7c: KFileItem: call stat() on demand, add
SkipMimeTypeDetermination option (authored by hoffmannrobert, committed by
dfaure).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
hoffmannrobert marked 3 inline comments as done.
hoffmannrobert added a comment.
Yes, please, and https://phabricator.kde.org/D19784 too.
REPOSITORY
R241 KIO
BRANCH
add_skipStat
REVISION DETAIL
https://phabricator.kde.org/D19887
To: hoffmannrobert, dfaure, #frameworks, #dolphin
Cc:
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Thanks! Looks nice now.
I don't see you in the list of developer accounts, so I guess you need
someone to push this for you?
REPOSITORY
R241 KIO
BRANCH
add_skipStat
REVISION
hoffmannrobert marked 4 inline comments as done.
hoffmannrobert added inline comments.
INLINE COMMENTS
> dfaure wrote in kfileitem.cpp:362
> There is one thing I've been wondering back and forth about: the alternative
> way of doing this, which is to call init() unconditionally and testing the
hoffmannrobert updated this revision to Diff 55033.
hoffmannrobert marked 3 inline comments as done.
hoffmannrobert added a comment.
- Add ensureInitialized(), entry() changes
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19887?vs=55025=55033
BRANCH
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileitem.cpp:362
> +
> +if (!item.m_bInitCalled && m_bInitCalled) {
> +item.init();
There is one thing I've been wondering back and forth about:
hoffmannrobert marked 4 inline comments as done.
hoffmannrobert added inline comments.
INLINE COMMENTS
> dfaure wrote in kfileitem.cpp:361
> What about the other way around? I think this needs the symmetrical test to
> call item.init() if needed
> (and the corresponding unittest, write it
hoffmannrobert edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19887
To: hoffmannrobert, dfaure, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
hoffmannrobert updated this revision to Diff 55025.
hoffmannrobert added a comment.
- Fix cmp() #3, add test for cmp()/init(), simplifications
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19887?vs=54934=55025
BRANCH
add_skipStat
REVISION DETAIL
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileitem.cpp:86
> * Computes the text and mode from the UDSEntry
> * Called by constructor, but can be called again later
> * Nothing does
hoffmannrobert updated this revision to Diff 54934.
hoffmannrobert marked 4 inline comments as done.
hoffmannrobert added a comment.
- Fix cmp() #2
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19887?vs=54932=54934
BRANCH
add_skipStat
REVISION DETAIL
hoffmannrobert added a comment.
KFileItemTest::testCmp() failed - fixed.
JobTest also fails, but this fails in master, too. Something with FileCopyJob.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19887
To: hoffmannrobert, dfaure, #frameworks, #dolphin
Cc:
hoffmannrobert updated this revision to Diff 54932.
hoffmannrobert added a comment.
- Fix cmp(), SkipMimeTypeFromContent rename, change isDir()
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19887?vs=54862=54932
BRANCH
add_skipStat
REVISION DETAIL
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Thanks.
Did you also run the kio unittests to ensure they still pass?
INLINE COMMENTS
> kfileitem.cpp:203
> // stat() local files if needed
> // TODO: delay this
hoffmannrobert marked 5 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19887
To: hoffmannrobert, dfaure, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
hoffmannrobert retitled this revision from "Proposal for KFileItem to skip
stat()" to "KFileItem: call stat() on demand, add SkipMimeTypeDetermination
option".
hoffmannrobert edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19887
To:
16 matches
Mail list logo
