This revision was automatically updated to reflect the committed changes.
Closed by commit R295:d9ddd3524535: Add runtime guard that pages are KCMs in
KCMultiDialog (authored by davidedmundson).
REPOSITORY
R295 KCMUtils
CHANGES SINCE LAST UPDATE
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.
Approving since it's similar to what i did in
https://phabricator.kde.org/D19889
REPOSITORY
R295 KCMUtils
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D19888
To:
rikmills added a comment.
Patch seemed to fix the crash. I don't use Kontact (apart from testing things
like this), but on a quick test all seems functional once more.
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D19888
To: davidedmundson
Cc: rikmills,
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
This situation can come up if a KCMultiDialog subclass adds pages
directly that aren't KCModules.
