D20062: [RFC] Add support for changing volume label.

2020-08-09 Thread Claudius Ellsel 
clel added a comment.


  Another ping after over one year without action. Maybe the state of this 
issue is not really clear or the original author does not have time to 
implement the advise to their question. Still hopefully this can get continued 
soon, either way. @chinmoyr @broulik @bruns

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20062

To: chinmoyr, #frameworks, bruns, broulik
Cc: clel, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D20062: [RFC] Add support for changing volume label.

2019-06-05 Thread Nathaniel Graham 
ngraham added a comment.


  Ping, any update on this?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20062

To: chinmoyr, #frameworks, bruns, broulik
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D20062: [RFC] Add support for changing volume label.

2019-03-26 Thread Stefan Brüns 
bruns added a comment.


  This definitely should be part of the StorageVolume interface.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20062

To: chinmoyr, #frameworks, bruns, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20062: [RFC] Add support for changing volume label.

2019-03-26 Thread Chinmoy Ranjan Pradhan 
chinmoyr added a comment.


  The issue here is the placement of code. There are no API for changing any 
volume attributes so adding the changeLabel() method here feels awkward.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20062

To: chinmoyr, #frameworks, bruns, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20062: [RFC] Add support for changing volume label.

2019-03-26 Thread Nathaniel Graham 
ngraham added reviewers: bruns, broulik.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20062

To: chinmoyr, #frameworks, bruns, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20062: [RFC] Add support for changing volume label.

2019-03-26 Thread Chinmoy Ranjan Pradhan 
chinmoyr created this revision.
chinmoyr added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Is this the right approach to take?

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20062

AFFECTED FILES
  src/solid/devices/backends/fakehw/fakestorageaccess.cpp
  src/solid/devices/backends/fakehw/fakestorageaccess.h
  src/solid/devices/backends/fstab/fstabstorageaccess.cpp
  src/solid/devices/backends/fstab/fstabstorageaccess.h
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp
  src/solid/devices/backends/udisks2/udisksstorageaccess.h
  src/solid/devices/ifaces/storageaccess.cpp
  src/solid/devices/ifaces/storageaccess.h

To: chinmoyr, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns