D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

kossebau added a comment. In D20166#448914 , @cullmann wrote: > The CI is a bit unhappy with the gzip depedency on Windows. > Might one just write a minimal KArchive based gzip'er for this? gzip isn't there on any normal Windows machine, even

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

cullmann added a comment. The CI is a bit unhappy with the gzip depedency on Windows. Might one just write a minimal KArchive based gzip'er for this? gzip isn't there on any normal Windows machine, even if you have libz. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

This revision was automatically updated to reflect the committed changes. Closed by commit R242:38ba8beee3a5: Keep desktoptheme SVG files uncompressed in repo, install svgz (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20166?vs=55383=56025#toc REPOSITORY R242

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Sorry, I should learn to read... When following the instructions, this works flawlessly. Indeed, let's do it for 5.58 so we have lots of time for testing. Thanks for this very nice

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

kossebau added a comment. In D20166#443916 , @ngraham wrote: > In D20166#443781 , @kossebau wrote: > > > If so, I would propose to merge it after KDE Frameworks 5.57 has been branched this WE, i.e.

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

ngraham added a comment. In D20166#443781 , @kossebau wrote: > If so, I would propose to merge it after KDE Frameworks 5.57 has been branched this WE, i.e. merge Friday next week for another 7 days of consideration, but with some weeks before

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

kossebau added a comment. Recent example where plain SVGs in the repo would have made the change immdiate visible, as only the strings of some id attributes where changed (to match the new icon names), but instead all we see with our tool is an exchange of the complete binary blob: D20261

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

kossebau updated this revision to Diff 55383. kossebau added a comment. Remove last bit about stripping that was still in the patch REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20166?vs=55231=55383 BRANCH uncompressedsvginrepo

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

ndavis added a comment. In D20166#441863 , @kossebau wrote: > IMHO the SVG files in the repo may contain comments and metadatas, for further work on them. Like source code also has all the oomments and metadata. > Only the deployed graphics

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

bruns added a comment. In D20166#441854 , @ndavis wrote: > In D20166#441807 , @ngraham wrote: > > > Strictly speaking, there's no need to optimize the SVGs as a part of this, so maybe, yeah, let's

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

kossebau retitled this revision from "Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz" to "Keep desktoptheme SVG files uncompressed in repo, install svgz". kossebau edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL