D20428: separe mobile text selection to avoid recursive imports

2019-04-15 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > ComboBox.qml:174 > id: mobileCursor > Private.MobileCursor { > target: textField Does this not need to be adjusted? `ComboBox` is broken here. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D20428: separe mobile text selection to avoid recursive imports

2019-04-10 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R242:58dd4c5c0f12: separe mobile text selection to avoid recursive imports (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20428?vs=55885=55888#toc REPOSITORY R242 Plasma

D20428: separe mobile text selection to avoid recursive imports

2019-04-10 Thread Eike Hein
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Works here now, thx! REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D20428 To: mart, #plasma, hein Cc: hein, kde-frameworks-devel,

D20428: separe mobile text selection to avoid recursive imports

2019-04-10 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY the mobile text selection toolbar uses toolbuttons, which in turn use the private import.