D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown

2019-04-10 Thread loh tar
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:6ba329f8d451: KateIconBorder: Ensure Dyn Wrap Marker are 
shown (authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20431?vs=55893=55957

REVISION DETAIL
  https://phabricator.kde.org/D20431

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars


D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown

2019-04-10 Thread Dominik Haumann
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  As I understand, one can still disable the indicator if not wanted, right?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20431

To: loh.tar, cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars


D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown

2019-04-10 Thread loh tar
loh.tar added a comment.


  Diff on top of D20425 , not sure if 
depend on

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20431

To: loh.tar, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann


D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown

2019-04-10 Thread loh tar
loh.tar created this revision.
loh.tar added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

TEST PLAN
  - Ensure you have Dnamic Word Wrap *disabled* on KWrite start-up but *Always 
ON* to show wrap indicators; Config->Appearance->General
  - Start KWrite, enter long enough lines
  - Hit F10 to enable Dnamic Word Wrap
  - Lines should now be wrapped and wrap indicators shown, at least with this 
patch

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20431

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann