D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

2019-04-12 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:580fec7c0b20: [KDynamicJobTracker] When kuiserver 
isnt available, also fall back to widget… (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20465?vs=55984=56052

REVISION DETAIL
  https://phabricator.kde.org/D20465

AFFECTED FILES
  src/widgets/kdynamicjobtracker.cpp

To: broulik, #frameworks, dfaure, lbeltrame
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

2019-04-12 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20465

To: broulik, #frameworks, dfaure, lbeltrame
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

2019-04-11 Thread Luca Beltrame 
lbeltrame added a comment.


  +1.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20465

To: broulik, #frameworks, dfaure, lbeltrame
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

2019-04-11 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20465

To: broulik, #frameworks, dfaure, lbeltrame
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

2019-04-11 Thread Kai Uwe Broulik 
broulik added a comment.


  I think so, it's the very same patch in that bugreport :) So, this patch 
makes even more sense, I only considered the Plasma case

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20465

To: broulik, #frameworks, dfaure, lbeltrame
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

2019-04-11 Thread Nathaniel Graham 
ngraham added a comment.


  Does this fix https://bugs.kde.org/show_bug.cgi?id=379887?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20465

To: broulik, #frameworks, dfaure, lbeltrame
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

2019-04-11 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Frameworks, dfaure, lbeltrame.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It asks kuiserver whether we need to display a widget job tracker.
  However, kuiserver itself might not be available at this point, so handle the 
call itself failing, too.

TEST PLAN
  In preparation to kill kuiserver and move what it does into plasmashell
  
  Killed plasmashell, got a dialog now that kuiserver dbus service didn't 
autostart anymore

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20465

AFFECTED FILES
  src/widgets/kdynamicjobtracker.cpp

To: broulik, #frameworks, dfaure, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns